Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical refactoring permissions #397

Merged
merged 66 commits into from
Nov 29, 2022
Merged

Conversation

Fancien
Copy link
Collaborator

@Fancien Fancien commented Nov 16, 2022

  • Refactoring permission system to include permission target in the permission codename, increasing code readability
  • Adding permission requirements to model views
  • Adding tests to assert that urls return a 403 html error when user does not have permission to access that url.
  • On dataset permissions management page, added the list of users with permissions inherited from parent project
  • On user management page, adding the list of entities on which this user has permission
  • Forbid users to change Access status to "Active" if user is not data steward

Fancien and others added 30 commits November 3, 2022 08:30
Removing DELETE perm from LegalGroup.
Correcting general permissions tests
Adding tests for documents
README.md Outdated Show resolved Hide resolved
core/models/access.py Outdated Show resolved Hide resolved
core/models/legal_basis.py Outdated Show resolved Hide resolved
core/permissions/checker.py Outdated Show resolved Hide resolved
web/templates/datasets/dataset.html Outdated Show resolved Hide resolved
web/templates/permissions.html Show resolved Hide resolved
@neoflex neoflex assigned Fancien and unassigned neoflex Nov 21, 2022
…tes, added error catching for deleted contacts in Access model.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants