-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Technical refactoring permissions #397
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Fancien
commented
Nov 16, 2022
- Refactoring permission system to include permission target in the permission codename, increasing code readability
- Adding permission requirements to model views
- Adding tests to assert that urls return a 403 html error when user does not have permission to access that url.
- On dataset permissions management page, added the list of users with permissions inherited from parent project
- On user management page, adding the list of entities on which this user has permission
- Forbid users to change Access status to "Active" if user is not data steward
…m/elixir-luxembourg/daisy into technical-refactoring-permissions
Removing DELETE perm from LegalGroup. Correcting general permissions tests
… future). Adding tests for Dataset
Adding tests for documents
…m/elixir-luxembourg/daisy into technical-refactoring-permissions
…m/elixir-luxembourg/daisy into technical-refactoring-permissions
…m/elixir-luxembourg/daisy into technical-refactoring-permissions
… test_excel_export for new permissions
…m/elixir-luxembourg/daisy into technical-refactoring-permissions
neoflex
requested changes
Nov 21, 2022
…tes, added error catching for deleted contacts in Access model.
neoflex
approved these changes
Nov 22, 2022
This was referenced Nov 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.