feat: auditors cannot upload/delete the document #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vildead
requested changes
Jul 6, 2022
web/views/documents.py
Outdated
| @@ -98,13 +98,18 @@ def download_document(request, pk): | |||
| @permission_required(Permissions.PROTECTED, (Document, 'pk', 'pk')) | |||
| def delete_document(request, pk): | |||
| document = get_object_or_404(Document, pk=pk) | |||
|
|
|||
| if not request.user.is_superuser and not document.can_user_delete(request.user): | |||
There was a problem hiding this comment.
This is too restrictive. We can rely on PROTECTED decorator here.
Lets just check if the user is auditor
if yes -> 403
if no -> continue
The same should be done for upload_document() - which should also get a PROTECTED decorator
vildead
changed the title
vildead
changed the title
vildead
force-pushed
the
correct-who-can-delete-the-document
branch
from
c164240
to
bccb967
Compare
vildead
approved these changes
Jul 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.