Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add project start_date to index #212

Merged
merged 1 commit into from
May 25, 2021

Conversation

vildead
Copy link
Member

@vildead vildead commented Apr 15, 2021

Closes #152

Copy link
Member

@pinarpink pinarpink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vildead I am not sure if we should index based on date. I remember we had exact date indexing very early on in DAISY and it results in a veery long list in the StartDate facet box of Project search page

@vildead
Copy link
Member Author

vildead commented May 3, 2021

@vildead I am not sure if we should index based on date. I remember we had exact date indexing very early on in DAISY and it results in a veery long list in the StartDate facet box of Project search page

@pinar - I see. That would be really long. But it seems the Date facet box is not there any more - just Start/End Year.
We can change the ordering Start date to Start year - then there will be no need for the date in index. Let me know if you agree.

Screenshot from 2021-05-03 14-51-56

@pinarpink
Copy link
Member

@vildead I am not sure if we should index based on date. I remember we had exact date indexing very early on in DAISY and it results in a veery long list in the StartDate facet box of Project search page

@pinar - I see. That would be really long. But it seems the Date facet box is not there any more - just Start/End Year.
We can change the ordering Start date to Start year - then there will be no need for the date in index. Let me know if you agree.

Screenshot from 2021-05-03 14-51-56

If the newly prepared exact date index field will be used for sorting only then ignore my comments. I had assumed there would be a facet. Go ahead.

@vildead
Copy link
Member Author

vildead commented May 25, 2021

@vildead I am not sure if we should index based on date. I remember we had exact date indexing very early on in DAISY and it results in a veery long list in the StartDate facet box of Project search page

@pinar - I see. That would be really long. But it seems the Date facet box is not there any more - just Start/End Year.
We can change the ordering Start date to Start year - then there will be no need for the date in index. Let me know if you agree.
Screenshot from 2021-05-03 14-51-56

If the newly prepared exact date index field will be used for sorting only then ignore my comments. I had assumed there would be a facet. Go ahead.

Yes, thats correct. The new index field is just for sorting :)

@vildead vildead closed this May 25, 2021
@vildead vildead reopened this May 25, 2021
@pinarpink pinarpink merged commit aa60c82 into develop May 25, 2021
@vildead vildead deleted the 152-sorting-projects-by-start-date branch July 20, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting projects by start date returns "No results"
2 participants