-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to importer #203
Merged
pinarpink
merged 16 commits into
elixir-luxembourg:fixes-to-importer
from
vildead:fixes-to-importer
Apr 8, 2021
Merged
Fixes to importer #203
pinarpink
merged 16 commits into
elixir-luxembourg:fixes-to-importer
from
vildead:fixes-to-importer
Apr 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [django](https://github.com/django/django) from 2.2.13 to 2.2.18. - [Release notes](https://github.com/django/django/releases) - [Commits](django/django@2.2.13...2.2.18) Signed-off-by: dependabot[bot] <support@github.com>
when the source study/cohort for data_dec does not exists, the working will now contain also data declaration title
vildead
force-pushed
the
fixes-to-importer
branch
from
April 1, 2021 09:03
0f00ee7
to
e28d689
Compare
pinarpink
reviewed
Apr 1, 2021
|
||
cohort, _ = Cohort.objects.get_or_create( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not get_or_create by just title? The more you increase parameters to get_or_create the more likely you will create new records for same cohort.
pinarpink
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.