New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added dockerignore, splitted Dockerfile to enable layers caching #128

Merged

neoflex merged 1 commit into develop from 122-improve-dockerfile

Feb 24, 2020

Collaborator

jLebioda commented Feb 6, 2020

It does not affect traditional (non-docker) deployments, but optimizes Docker-based deployments.
What has been changed?

Added .dockerignore file. It results in Docker ignoring the specified files on building of the container.
For more details why it's important, see this short article
Splitted copying files into the container into two steps, which result in 1-6x speedup in consequent container build time (if the container was built previously on the same machine, it will use the cached results from previous build, unless you change setup.py file)


          chore: added dockerignore, splitted Dockerfile to enable layers caching

65258d1

jLebioda added the waiting-for-merge label

jLebioda requested review from neoflex and pinarpink

February 6, 2020 14:32

jLebioda assigned pinarpink

neoflex approved these changes

View reviewed changes

neoflex merged commit 95ee99b into develop

neoflex deleted the 122-improve-dockerfile branch

February 24, 2020 12:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-merge