Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delete confirmation dialogs. #18

Closed
pinarpink opened this issue Jun 15, 2019 · 2 comments
Closed

Add delete confirmation dialogs. #18

pinarpink opened this issue Jun 15, 2019 · 2 comments
Assignees
@vildead
Labels
to-be-verified
Milestone
m_01

Comments

@pinarpink
Copy link
Member

No description provided.

@pinarpink pinarpink added this to the m_01 milestone Jun 15, 2019
@pinarpink pinarpink self-assigned this Jul 6, 2019
@pinarpink
Copy link
Member Author

pinarpink commented Jul 7, 2019 •
edited
Loading

@neoflex can you please have a look at branch https://github.com/elixir-luxembourg/daisy/tree/Add-delete-confirmation-dialogs-%2318
Added confirm dialog, meanwhile replaced the removal ".deletable" parents with page reload.
The messages from the deletion action were not displayed before.
Are you OK with page reload, or should I stick to parent removal, what about messages?

pinarpink pushed a commit that referenced this issue Jul 13, 2019
Merge branch 'Add-delete-confirmation-dialogs-#18' into develop
4a11d94
@pinarpink pinarpink assigned vildead and unassigned pinarpink Jul 30, 2019
@vildead
Copy link
Member

vildead commented Jul 31, 2019

closing the issue. Verified on commit: c4014c7

@vildead vildead closed this as completed Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vildead vildead

Labels
to-be-verified
Projects
None yet
Milestone
m_01
Development

No branches or pull requests
2 participants
@pinarpink @vildead