Pass sigil/modifiers through to formatter

[maartenvanvliet]

I created a formatter for graphql documents, see this PR absinthe-graphql/absinthe#1114 (comment) and @benwilson512 asked whether the formatting could be dependent on whether it's a sigil being formatted or a file.

As mentioned in the discussion it can be inferred by checking the extension of the file being formatted, but this seems brittle. Also it doesn't pass through which sigil is used or any of the applied sigil modifiers. This PR changes that by passing through sigil: {name, modifiers} to the opts of the format(content, opts) in a formatter plugin.

[josevalim]

Thank you! This is perfect feedback just in time for the release. I have dropped two tiny comments. Also, I have a question: should we pass those as arguments instead of options then? We can have a first argument being {:extension, ".w"} | {:sigil, :W, 'modifier'}. I think I prefer your current approach, but I thought I would ask.

Also, finally, can you please update the docs to talk about those? We need to update one of Code.format_* docs and the docs for mix format plugins.

[maartenvanvliet]

One note, the opening delimiter of the sigil could also be passed in the tuple. I don't think it adds much here but since it's public facing it would be harder to add later on. Wdyt?

[josevalim]

@maartenvanvliet we can always add that as a separate option. Maybe it should be sigil: :W, modifiers: []? Then it is easier to add delimiter later on?

[maartenvanvliet]

Yes, let's do that

[josevalim]

Alright, I will wait for that and once it is ready I will ship it. :)

[josevalim]

💚 💙 💜 💛 ❤️

[benwilson512]

This is amazing! ❤️