allow-local-unix-socket #404
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polvalente
reviewed
Feb 10, 2025
| @@ -293,6 +293,9 @@ defmodule GRPC.Server.Adapters.Cowboy do | |||
| :undefined -> | |||
| raise "undefined address for ranch server" | |||
|
|
|||
| :local -> | |||
There was a problem hiding this comment.
As with the other PR, please add tests for the change.
There was a problem hiding this comment.
I believe when using :local, the handling of the address would be a bit different as it needs the socket file returned in port to decide which is the unix file descriptor handling the connection
There was a problem hiding this comment.
Actually, seeing as this is only used in logs, we can perhaps add that info to Logger.metadata and return "local" as it is now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.