Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow client settings opt on mint adapter #378

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

beligante
Copy link
Contributor

Hey Team, I've been actively working on this: #307 but so far no good results.

Tho, I've noticed that with a few tweaks in the configs, it's possible to improve the Mint adapter performance by 2x (which still slow if compared with gun, but it's a quick win)

This PR aims to accept a new option when starting the connection where it's possible to pass Mint's client settings options and also setting a bigger window size as default (I got these values from Gun )

I also have a branch where , with the supposer of benchee I can compare the improvement on speed

beligante#4

@sleipnir sleipnir merged commit 5ee86be into elixir-grpc:master Jul 10, 2024
8 checks passed
@beligante beligante deleted the allow-client-settings-opt-mint branch July 10, 2024 18:26
@sleipnir
Copy link
Collaborator

Thank you @beligante
You pretend to follow soon with #377 ?
I think we are accumulating enough in main to generate a new version. But it's very interesting and if we work on it quickly we can wait.

@beligante
Copy link
Contributor Author

Thank you @beligante
You pretend to follow soon with #377 ?
I think we are accumulating enough in main to generate a new version. But it's very interesting and if we work on it quickly we can wait.

Yup! I've finished the code changes already, I'm working on some tests. Probably later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants