Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve some doc warnings #250

Merged
merged 17 commits into from
Jul 29, 2022
Merged

Conversation

polvalente
Copy link
Contributor

@polvalente polvalente commented Jul 23, 2022

closes #249

@wingyplus
Copy link
Contributor

@polvalente you may need to add start_server to this line https://github.com/elixir-grpc/grpc/blob/master/interop/script/run.exs#L17 since interop test does not starting a server

@polvalente
Copy link
Contributor Author

@polvalente you may need to add start_server to this line https://github.com/elixir-grpc/grpc/blob/master/interop/script/run.exs#L17 since interop test does not starting a server

The problem was that nil or ... doesn't work. It should have been opts[:start_server] || ..., but I refactored into a cond instead

Copy link
Contributor

@wingyplus wingyplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polvalente polvalente merged commit da37494 into master Jul 29, 2022
@polvalente polvalente deleted the pv-chore/resolve-some-doc-warnings branch July 29, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GRPC.Server.Adapters.Cowboy.Handler.state document is missing
2 participants