Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Expo for handling built-in plural forms #347

Merged
merged 2 commits into from
Jan 21, 2023
Merged

Use Expo for handling built-in plural forms #347

merged 2 commits into from
Jan 21, 2023

Conversation

whatyouhide
Copy link
Contributor

No description provided.

@whatyouhide whatyouhide requested a review from maennchen January 21, 2023 08:46
whatyouhide
whatyouhide commented Jan 21, 2023
View reviewed changes
mix.exs Outdated
Comment on lines 52 to 53
# {:expo, "~> 0.1.0 or ~> 0.2.0"},
{:expo, github: "elixir-gettext/expo"},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll update this once we release a new Expo version.

@coveralls
Copy link

coveralls commented Jan 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5c8e544aff93bf37eb8082a6ec7b39d279c96b46-PR-347

  • 13 of 15 (86.67%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.007%) to 90.603%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/gettext/plural.ex 13 15 86.67%
Files with Coverage Reduction New Missed Lines %
lib/gettext/plural.ex 1 86.49%
Totals Coverage Status
Change from base Build 9943eaf12fbdf18f99ddf994c1e3e7415841a79a: 1.007%
Covered Lines: 511
Relevant Lines: 564
💛 - Coveralls

@whatyouhide whatyouhide merged commit 7b350bc into main Jan 21, 2023
@whatyouhide whatyouhide deleted the al/expo-plural branch January 21, 2023 09:39
@maennchen maennchen mentioned this pull request Jan 21, 2023
Closed
ravensiris pushed a commit to ravensiris/gettext that referenced this pull request Aug 3, 2023
@whatyouhide @ravensiris
Use Expo for handling built-in plural forms (elixir-gettext#347)
63d726e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maennchen maennchen maennchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whatyouhide @coveralls @maennchen