Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile #115

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Update Makefile #115

merged 2 commits into from
Jan 21, 2025

Conversation

DnOberon
Copy link
Contributor

  • catch-all on makefile for automated pipelines

This is particularly for Burrito which expects elixir_make files to have an all target. I don't necessarily see an issue adding an alias to the adbc target for all - but I'm also no C expert. Let me know if you think this would be an issue?

catch-all for automated pipelines
Makefile Outdated Show resolved Hide resolved
@josevalim josevalim merged commit ccd2385 into elixir-explorer:main Jan 21, 2025
3 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@DnOberon
Copy link
Contributor Author

I appreciate this being looked at @josevalim - but the reason I choose the adbc target was because it respected the correct flags when cross compiling. Unfortunately the change you made doesn't allow for cross compiling with Burrito :\

The flags correctly set the target, but appear to set a different arch? I was able to cross compile just fine with the adbc target however. I'm still learning this lower level compiling so forgive my ignorance here :)

-target x86_64-windows -O2 -dynamic -shared -Wl,-undefined=dynamic_lookup    -arch arm64 
......
 zig: error: unsupported option '-arch' for target 'x86_64-unknown-windows-gnu'

@josevalim
Copy link
Member

Oh, apologies then. I did the changes to fix the build but then I broke your use case. :D The command invoke by Burrito is not customizable? Anyway, I will push a fix that makes both CI and Burrito happy.

@josevalim
Copy link
Member

Pushed to main!

@DnOberon
Copy link
Contributor Author

@josevalim thank you - I've got some time I'm going to put into helping Burrito's build step be a little more customizable on the flags passed to the compiler - but for now this keeps us moving. You're the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants