Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video music still plays when Youtube downloader window is closed #302

Closed
otseng opened this issue Mar 22, 2021 · 4 comments
Closed

Video music still plays when Youtube downloader window is closed #302

otseng opened this issue Mar 22, 2021 · 4 comments
Assignees
@eliranwong
Labels
bug Something isn't working

Comments

@otseng
Copy link
Collaborator

otseng commented Mar 22, 2021

To duplicate:

  • Highlight text
  • Select Context/Plugins/Youtube Downloader
  • Play a video
  • Close the window

The window will close, but the video audio is still running.

Duplicated on Mac and Ubuntu.
@eliranwong
Copy link
Owner

I noted the issue too, but haven't managed to find a complete solution.

A temporary solution is to stop the music before closing the window.

@eliranwong
Copy link
Owner

I think of a solution, will test and let you know.

@eliranwong eliranwong added the bug Something isn't working label Mar 22, 2021
@eliranwong eliranwong self-assigned this Mar 22, 2021
@eliranwong
Copy link
Owner

@otseng I think it is now fixed, but please help check if it works on your side too. thanks.

9bd732f

@otseng
Copy link
Collaborator Author

otseng commented Mar 22, 2021

yes, it works now!

otseng added a commit that referenced this issue Dec 15, 2024
@otseng
Fix change icon size (#302) (#1484)
06e2235
eliranwong pushed a commit that referenced this issue Dec 16, 2024
@otseng
Fix change icon size (#302)
4ff7c4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eliranwong eliranwong

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@otseng @eliranwong