Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PEP 517 build #80

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Conversation

Rohan-cod
Copy link
Contributor

@Rohan-cod Rohan-cod commented Jun 17, 2021

Description

Updated setup.cfg, deleted setup.py, and added build time requirements in pyproject.toml to shift the build process to PEP 517.

Fixes #18

How Has This Been Tested?

The code has been tested by running all the unit tests using the command python -m unittest, validated the PEP 8 formatting using pycodestyle and deployed the build to pypi to test if it is installed without any errors using pip.

  • Unit Tests
  • PEP 8 Formatting Validation
  • pip install package_name

Updated setup.cfg, deleted setup.py and added build time requirements in pyproject.toml to shift the build process to PEP 517.
@srgothi92
Copy link
Contributor

srgothi92 commented Jun 17, 2021

Can you try deploying the binary to https://test.pypi.org/ and download via pip and confirm everything works without cython and wheel installation. One more thing that we need to take care is what if user upgrades from older build to newer build, does it break anything ?

Can you also update How Has This Been Tested? section correctly, just running unit test and integration test is not enough for this change.

@Rohan-cod
Copy link
Contributor Author

Hi @srgothi92,
I deployed the package on pypi. Even after adding a pyproject.toml, I am still getting the same error - No module named 'Cython'. I also tried adding a MANIFEST.in to include pyproject.toml but still the same error. I think it can be resolved when pyrle is updated.

@Rohan-cod
Copy link
Contributor Author

One more thing that we need to take care is what if user upgrades from older build to newer build, does it break anything ?

I tested this one just now. First I deployed the package with the older build process and installed it via pip. Then I shifted the build process to PEP 517 and upgraded it. I was able to upgrade it without any errors
Screenshot 2021-06-17 at 10 46 59 PM

@srgothi92
Copy link
Contributor

I deployed the package on pypi. Even after adding a pyproject.toml, I am still getting the same error - No module named 'Cython'. I also tried adding a MANIFEST.in to include pyproject.toml but still the same error. I think it can be resolved when pyrle is updated.

Can you remove all the changes that you did for this and keep only the changes required for PEP-517 build.

@Rohan-cod
Copy link
Contributor Author

Can you remove all the changes that you did for this and keep only the changes required for PEP-517 build.

@srgothi92, actually I made all those changes(like adding the MAINFEST.in file) on my local machine and then deployed it to PyPI. This pull request only has the changes required for PEP 517.

Copy link
Contributor

@srgothi92 srgothi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the Readme file also.

@Rohan-cod
Copy link
Contributor Author

Can you update the Readme file also.

Hi @srgothi92, can you please tell what needs to be updated in the README. Do I need to add information related to PEP 517 build process?

@srgothi92
Copy link
Contributor

Can you update the Readme file also.

Hi @srgothi92, can you please tell what needs to be updated in the README. Do I need to add information related to PEP 517 build process?

Sorry, my bad. This PR is ready to be merged.
I meant the CHANGELOG file in this PR, mention we are changing the build process to PEP-517 in this release.

@rhdolin rhdolin merged commit b2fcecc into elimuinformatics:master Jun 29, 2021
@Rohan-cod Rohan-cod deleted the pep-517 branch June 29, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift the build process to PEP-517
3 participants