Switch from PyVCF to PyVCF3 and update workflow to install dependencies from requirements.txt #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyVCF is no longer maintained by anyone and has issues. PyVCF3, a fork of PyVCF fixes all the issues.
Update requirements.txt
rhdolin
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request consists of two commits:
PyVCFtoPyVCF3as the former is no longer maintained.requirements.txtinstead of installing thevcf2fhirpackage usingpip.How Has This Been Tested?
The code has been tested by running all the tests using
python -m unittestand the PEP 8 formatting was validated usingpycodestyle.