Update chartjs-plugin-annotation to version 3.1.0 #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semicolin
requested changes
Feb 21, 2025
Comment on lines
48
to
50
| @Injectable() | ||
| @Injectable({ | ||
| providedIn: 'root', | ||
| }) |
There was a problem hiding this comment.
Why was this changed to provide in root? Mappers should not be provided in the root injector. Apps should use provideChartsOnFhir(withMappers(...))
There was a problem hiding this comment.
Yes, you are right, I made a mistake while running the showcase with mock data. I will remove this.
Comment on lines
7
to
9
| @Injectable() | ||
| @Injectable({ | ||
| providedIn: 'root', | ||
| }) |
There was a problem hiding this comment.
Why was this changed to provided in root?
…dd PatientService to AppComponent providers
|
vdeshkar
changed the title
semicolin
approved these changes
Feb 21, 2025
shubhamparikh927
approved these changes
Feb 24, 2025
yashpmohod
approved these changes
Feb 24, 2025
vdeshkar
deleted the
RT-1886-charts-on-fhir-upgrade-annotation-plugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
How it was tested
Checklist