Add 'doi' field to ExternalVersionSummary [elifesciences/enhanced-pre…

…prints-issues#1139]
elifesciences · Jul 9, 2024 · 95e0499 · 95e0499
1 parent a2c1fb6
commit 95e0499
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/src/http-schema/http-schema.test.ts b/src/http-schema/http-schema.test.ts
@@ -87,6 +87,7 @@ const enhancedArticleExample = {
 const externalVersionSummaryExample = {
   id: 'testid2',
   msid: 'testmsid1',
+  doi: 'doi2',
   url: 'https://doi.org/doi2',
   versionIdentifier: '2',
   published: '2023-02-28',
@@ -398,6 +399,7 @@ describe('httpschema (EnhancedArticleSchema)', () => {
 
 describe('httpschema (ExternalVersionSummarySchema)', () => {
   const sampleRequiredFieldValidationMessages = [
+    '"doi" is required',
     '"url" is required',
     '"versionIdentifier" is required',
   ];
@@ -433,6 +435,7 @@ describe('httpschema (ExternalVersionSummarySchema)', () => {
     const invalidateCorrections = ExternalVersionSummarySchema.validate({
       id: 'id',
       msid: 'msid',
+      doi: 'doi',
       versionIdentifier: 'v42',
       published: '2008-11-02',
       url: 'www.google.com',
@@ -459,6 +462,7 @@ describe('httpschema (ExternalVersionSummarySchema)', () => {
     const input = {
       id: 'id',
       msid: 'msid',
+      doi: 'doi',
       versionIdentifier: 'v42',
       published: '2008-11-02',
       url: 'www.google.com',

diff --git a/src/http-schema/http-schema.ts b/src/http-schema/http-schema.ts
@@ -236,6 +236,7 @@ export const RelatedContentSchema = Joi.array().items({
 export const ExternalVersionSummarySchema = Joi.object<VersionSummary>({
   id: Joi.string().required(),
   msid: Joi.string().required(),
+  doi: Joi.string().required(),
   url: Joi.string().required(),
   versionIdentifier: Joi.string().required(),
   published: Joi.date().required().allow(null),

diff --git a/src/model/model.ts b/src/model/model.ts
@@ -151,13 +151,14 @@ type PreprintVersionSummary = Omit<EnhancedArticle, 'article' | 'peerReview'>;
 type ExternalVersionSummary = {
   id: string,
   msid: string,
+  doi: string,
   versionIdentifier: string,
   published?: Date,
-  url: string
+  url: string,
   corrections?: {
     url: string,
     date: Date,
-  }[]
+  }[],
 };
 
 export type VersionSummary = PreprintVersionSummary | ExternalVersionSummary;