Make the ElifeAssessment's title mandatory

elifesciences/issues#9034
elifesciences · Jan 9, 2025 · 235eca8 · 235eca8
1 parent 4a77703
commit 235eca8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/Model/ElifeAssessment.php b/src/Model/ElifeAssessment.php
@@ -12,7 +12,7 @@ final class ElifeAssessment implements Model
      * @internal
      */
     public function __construct(
-        string $title = null,
+        string $title,
         array $significance = null,
         array $strength = null
     ) {
@@ -21,10 +21,7 @@ public function __construct(
         $this->strength = $strength;
     }
 
-    /**
-     * @return string|null
-     */
-    public function getTitle()
+    public function getTitle(): string
     {
         return $this->title;
     }

diff --git a/test/Builder.php b/test/Builder.php
@@ -278,7 +278,7 @@ private function defaultTestData()
                 },
                 ElifeAssessment::class => function () {
                     return [
-                        'title' => null,
+                        'title' => 'eLife Assessment',
                         'significance' => ['Landmark', 'Important'],
                         'strength' => ['Solid', 'Adequate'],
                     ];