Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Native SSR Sample #64

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Fix: Native SSR Sample #64

merged 1 commit into from
Nov 18, 2022

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Nov 18, 2022 •
edited by pull-request-badge bot
Loading

Ready for review Powered by Pull Request Badge

This changeset applies a fix to the React SSR sample for an error where kotlin.random.Random is missing.

Changelog

  • Link to stdlib and stdlib-jdk8 explicitly in app module
  • Make sure kotlin.random.Random can be resolved via reflection

@sgammon sgammon added ci:build-img-jvm Trigger JVM Docker image builds ci:build-img-native Trigger native Docker image builds ci:build-native Build native targets in CI platform:jvm PRs and issues relating to JVM support. ci:test-native Run native tests ci:deploy-samples Deploy sample apps labels Nov 18, 2022
@sgammon sgammon added this to the Release R1: Alpha 1 milestone Nov 18, 2022
@sgammon sgammon self-assigned this Nov 18, 2022
@github-actions github-actions bot removed ci:build-img-native Trigger native Docker image builds ci:build-img-jvm Trigger JVM Docker image builds platform:jvm PRs and issues relating to JVM support. labels Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022 •
edited
Loading

Codecov Report

Merging #64 (579d26c) into v3 (5d7390c) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                 v3      #64      +/-   ##
============================================
- Coverage     67.65%   67.39%   -0.27%     
  Complexity      369      369              
============================================
  Files            72       73       +1     
  Lines          2557     2567      +10     
  Branches        225      225              
============================================
  Hits           1730     1730              
- Misses          755      765      +10     
  Partials         72       72
Impacted Files Coverage Δ
...src/main/kotlin/elide/runtime/graalvm/JsRuntime.kt 29.48% <0.00%> (-0.09%) ⬇️
...n/kotlin/elide/runtime/graalvm/JsRuntimeFeature.kt 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d7390c...579d26c. Read the comment docs.

@sgammon sgammon added ci:build-img-jvm Trigger JVM Docker image builds ci:build-img-native Trigger native Docker image builds platform:jvm PRs and issues relating to JVM support. labels Nov 18, 2022
@github-actions github-actions bot removed ci:build-img-native Trigger native Docker image builds ci:build-img-jvm Trigger JVM Docker image builds labels Nov 18, 2022
@sgammon sgammon force-pushed the native/ssr-sample branch 2 times, most recently from 17d7547 to b3f073c Compare November 18, 2022 06:37
@sgammon sgammon added ci:build-img-jvm Trigger JVM Docker image builds ci:build-img-native Trigger native Docker image builds labels Nov 18, 2022
@github-actions github-actions bot removed ci:build-img-native Trigger native Docker image builds ci:build-img-jvm Trigger JVM Docker image builds labels Nov 18, 2022
@sgammon sgammon added ci:build-img-jvm Trigger JVM Docker image builds ci:build-img-native Trigger native Docker image builds labels Nov 18, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sgammon
Fix: Native SSR Sample
579d26c 
This changeset applies a fix to the React SSR sample for an error
where `kotlin.random.Random` is missing.

Changes enclosed:
- Link to `stdlib` and `stdlib-jdk8` explicitly in app module
- Make sure `kotlin.random.Random` can be resolved via reflection
- Fix SARIF paths emitted from Detekt

ci:build-img-jvm
ci:build-img-native
ci:deploy-samples

Signed-off-by: Sam Gammon <samuel.gammon@gmail.com>
@github-actions github-actions bot removed ci:build-img-native Trigger native Docker image builds ci:build-img-jvm Trigger JVM Docker image builds labels Nov 18, 2022
@sgammon sgammon added ci:build-img-jvm Trigger JVM Docker image builds ci:build-img-native Trigger native Docker image builds labels Nov 18, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sgammon sgammon temporarily deployed to samples November 18, 2022 09:07 Inactive
@sgammon sgammon merged commit d0eadf0 into v3 Nov 18, 2022
@sgammon sgammon deleted the native/ssr-sample branch November 18, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sgammon sgammon

Labels
ci:build-img-jvm Trigger JVM Docker image builds ci:build-img-native Trigger native Docker image builds ci:build-native Build native targets in CI ci:deploy-samples Deploy sample apps ci:test-native Run native tests platform:jvm PRs and issues relating to JVM support.
Projects
Elide
Status: Done
Milestone
Release R1: Alpha 1
Development

Successfully merging this pull request may close these issues.
1 participant
@sgammon