Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak: Theme settings page [ED-11811] #318

Merged
merged 18 commits into from
Oct 10, 2023
Merged

Tweak: Theme settings page [ED-11811] #318

merged 18 commits into from
Oct 10, 2023

Conversation

rami-elementor
Copy link
Member

No description provided.

@rami-elementor rami-elementor changed the title Tweak: Theme settings page [ED-11811] Tweak: Theme settings page [ED-12018] Sep 27, 2023
KingYes
KingYes requested changes Sep 27, 2023
View reviewed changes
assets/dev/js/admin/pages/main-page.js Outdated Show resolved Hide resolved
KingYes
KingYes requested changes Sep 28, 2023
View reviewed changes
functions.php Outdated Show resolved Hide resolved
includes/settings/settings-panel.php Outdated Show resolved Hide resolved
includes/settings/settings-panel.php Outdated Show resolved Hide resolved
bainternet
bainternet requested changes Oct 5, 2023
View reviewed changes
assets/dev/js/admin/pages/main-page.js Outdated Show resolved Hide resolved
includes/settings-functions.php Outdated Show resolved Hide resolved
assets/dev/js/admin/pages/main-page.js Outdated Show resolved Hide resolved
assets/dev/js/admin/pages/main-page.js Outdated Show resolved Hide resolved
@rami-elementor rami-elementor changed the title Tweak: Theme settings page [ED-12018] Tweak: Theme settings page [ED-11811] Oct 8, 2023
bainternet
bainternet requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@bainternet bainternet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better,

  • left a suggestion for is_callable
  • I would also move all PHP settings in to constants but not a must.
  • The react is much more readable now, I would go even farther and move all settings logic to a custom hook.

@rami-elementor @bainternet
Apply suggestions from code review
c344df5 
Co-authored-by: Raz Ohad <admin@bainternet.info>
@KingYes KingYes merged commit ed7abb9 into develop Oct 10, 2023
5 of 7 checks passed
@KingYes KingYes deleted the settings-page branch October 10, 2023 10:10
@rami-elementor rami-elementor mentioned this pull request Oct 10, 2023
Merged
@rami-elementor
Copy link
Member Author

Looks better,

  • left a suggestion for is_callable
  • I would also move all PHP settings in to constants but not a must.
  • The react is much more readable now, I would go even farther and move all settings logic to a custom hook.

@bainternet See #320 320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bainternet bainternet bainternet requested changes

@KingYes KingYes KingYes approved these changes

@arielk arielk Awaiting requested review from arielk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rami-elementor @bainternet @KingYes