Internal: Replace Free to Pro Upsell Promotion - Heading Widget [ED-15838] #28929
+446
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…place-free-to-pro-upsell-promotion-heading-widget' into ED-15908-internal-replace-free-to-pro-upsell-promotion-create-react-component
…place-free-to-pro-upsell-promotion-heading-widget' into ED-15908-internal-replace-free-to-pro-upsell-promotion-create-react-component
hein-obox
reviewed
Oct 9, 2024
includes/managers/controls.php
Outdated
| @@ -1347,6 +1362,29 @@ private function promotion_switcher_control( $title, $id ): string { | |||
| </div>'; | |||
| } | |||
|
|
|||
| private function react_promotion_control( $title, $id ): string { | |||
| return '<div class="elementor-control-type-switcher elementor-label-inline e-control-motion-effects-promotion__wrapper"> | |||
There was a problem hiding this comment.
now this starts to look as lot of duplicated code. but to do some quick alignment of the infotip...
@hein-obox maybe, we should revert to the v1, when you tried to add an additional param to the promotion_control, to optionally render the "anchoring" element
There was a problem hiding this comment.
@mike-elementor Feel free to update this code to suite your requirements.
There was a problem hiding this comment.
@mike-elementor Let's try to avoid the duplication indeed.
…create-react-component' of https://github.com/elchugreeva/elementor into ED-15908-internal-replace-free-to-pro-upsell-promotion-create-react-component
…ree-to-pro-upsell-promotion-create-react-component' into ED-15908-internal-replace-free-to-pro-upsell-promotion-create-react-component
hein-obox
reviewed
Oct 10, 2024
| use Elementor\Modules\Home\Classes\Transformations_Manager; | ||
|
|
||
| class API { |
There was a problem hiding this comment.
I have extracted this code to a general class, in order make it reusable for other modules.
hein-obox
reviewed
Oct 10, 2024
| <App | ||
| colorScheme={ colorScheme } | ||
| isRTL={ isRTL } | ||
| promotionsData={ elementorPromotionsData } |
There was a problem hiding this comment.
The promotions data can be accessed from here.
hein-obox
reviewed
Oct 10, 2024
| } | ||
|
|
||
| private static function get_animated_headline_data( $assets_data ) { | ||
| $header_description = 'Get access to more features, widgets, and templates with Elementor Pro.'; |
There was a problem hiding this comment.
This is just a placeholder for now.
hein-obox
reviewed
Oct 13, 2024
| ] | ||
| ); | ||
| } | ||
|
|
||
| private function promotion_switcher_control( $title, $id ): string { | ||
| return '<div class="elementor-control-type-switcher elementor-label-inline e-control-motion-effects-promotion__wrapper"> |
There was a problem hiding this comment.
Maybe? Could you we replace this motion-effects reference with a more general reference?
hein-obox
reviewed
Oct 13, 2024
| PopperProps={ { | ||
| modifiers: [ | ||
| { | ||
| name: 'offset', |
There was a problem hiding this comment.
I would love to study this aspect in a bit more detail.
hein-obox
reviewed
Oct 13, 2024
| return ( | ||
| <Card sx={ { width: 296 } }> | ||
| <CardHeader title={ | ||
| <Box sx={ { display: 'flex', alignItems: 'center', justifyContent: 'space-between' } }> |
There was a problem hiding this comment.
Maybe;
``
Suggested change
| <Box sx={ { display: 'flex', alignItems: 'center', justifyContent: 'space-between' } }> | |
| <Box display="flex" alignItems="center" justifyContent="space-between"> |
I think this is the preferred approach for flexbox styling.
hein-obox
reviewed
Oct 13, 2024
| <Card sx={ { width: 296 } }> | ||
| <CardHeader title={ | ||
| <Box sx={ { display: 'flex', alignItems: 'center', justifyContent: 'space-between' } }> | ||
| <Box sx={ { display: 'flex', alignItems: 'center', gap: 1 } }> |
…create-react-component' of https://github.com/elchugreeva/elementor into ED-15908-internal-replace-free-to-pro-upsell-promotion-create-react-component
hein-obox
reviewed
Oct 14, 2024
| return self::filter_data( 'heading', $data ); | ||
| } | ||
|
|
||
| private static function filter_data( $filter_name, $asset_data ) { |
There was a problem hiding this comment.
Suggested change
| private static function filter_data( $filter_name, $asset_data ) { | |
| private static function filter_data( $widget_name, $promotion_name $asset_data ) { |
hein-obox
reviewed
Oct 14, 2024
| } | ||
|
|
||
| private static function filter_data( $filter_name, $asset_data ) { | ||
| return Filtered_Promotions_Manager::get_filtered_promotion_data( $asset_data, "elementor/widgets/{ $filter_name }/custom_promotion", 'upgrade_url' ); |
There was a problem hiding this comment.
Suggested change
| return Filtered_Promotions_Manager::get_filtered_promotion_data( $asset_data, "elementor/widgets/{ $filter_name }/custom_promotion", 'upgrade_url' ); | |
| return Filtered_Promotions_Manager::get_filtered_promotion_data( $asset_data, "elementor/widgets/{ $widget_name }/{ $promotion_name }", 'upgrade_url' ); |
hein-obox
reviewed
Oct 14, 2024
| 'upgrade_url' => 'https://go.elementor.com/go-pro-heading-widget/', | ||
| ]; | ||
|
|
||
| return self::filter_data( 'heading', $data ); |
There was a problem hiding this comment.
Suggested change
| return self::filter_data( 'heading', $data ); | |
| return self::filter_data( 'heading', 'animated_headline', $data ); |
…create-react-component' of https://github.com/elchugreeva/elementor into ED-15908-internal-replace-free-to-pro-upsell-promotion-create-react-component
…-promotion-create-react-component
…tion" was triggered
* fixed info-tip autoclose on click-away-listener (changed the child/parent relationships) * fixed close-button handler (on-click instead of on-close) * fixed into-tip positioning (right, tiny ux-improvement)
hein-obox
reviewed
Oct 15, 2024
| 'upgrade_url' => 'https://go.elementor.com/go-pro-heading-widget/', | ||
| ]; | ||
|
|
||
| return self::filter_data( 'animated-headline', $data ); |
There was a problem hiding this comment.
I am not sure if the widget name should be 'animated-headline' or 'heading'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.