-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set accent color based on wallpaper #263
Conversation
af25074
to
0411780
Compare
It seems to work, though I get warnings when switching:
|
…entary/switchboard-plug-pantheon-shell into set-accent-color-based-on-wallpaper
Works in conjunction with elementary/granite#483 |
I'm not sure what causes it, but when the Dark theme is selected, changing the accent color seems to toggle it to Default. |
Yes I can confirm the problem. I'll take a closer look. Good catch! |
@JoseExposito but for me the error occurs only in the settings... |
@JoseExposito I found it. Can you confirm that it works for you too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it works fine! 🎉
The code is fine, but I'd appreciate if someone with more experience working on this code base could have a look as well.
I left the UX review to @elementary/ux. I guess it is work in progress, but some wallpapers don't set the expected accent color.
@JoseExposito do you mean the accent colors for the included wallpapers? @cassidyjames had picked them by hand: elementary/settings-daemon#25 (comment) |
…entary/switchboard-plug-pantheon-shell into set-accent-color-based-on-wallpaper
* Try using a PNG for auto button * Stretch image to bounds
This reverts commit c94f475.
@meisenzahl so UI-wise this looks good, but I'm seeing and issue where the color gets out of sync with what is actually being set under the hood. I'm not sure if it's an issue in Gala or here, though. |
@cassidyjames this is an issue with this PR. The logic for Onboarding is working. I will fix this. |
@cassidyjames I found the problem. There was a missing line to set the |
@danrabbit thanks for the great suggestions! |
Goes with elementary/gala#1104
Works in conjunction with elementary/granite#483