Add support for libnm 1.43 #357
Merged
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tintou
reviewed
Apr 24, 2023
tintou
reviewed
Apr 24, 2023
|
Two suggestions but it looks good, this is due to a renamespace that I did in https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/4d325bafe193dc1fc4fbd0beabae7bb6ab8901bc |
tintou
reviewed
Apr 24, 2023
Co-authored-by: Corentin Noël <tintou@noel.tf>
|
@tintou thanks for your suggestions. I validated that it still compiles: https://github.com/meisenzahl/distro-agnostic/actions/runs/4782964418/jobs/8511499466 |
meisenzahl
commented
Apr 24, 2023
|
I'm unsure because odd number mean unstable release so at the end it would be HAS_NM_1_44 if we want to be correct 🤷 |
|
That would seem weird to me based on the version number. Then let's stick with |
tintou
approved these changes
Apr 24, 2023
|
NM 1.44 was released two months ago. It would be nice to have a tag supporting that version. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below are the versions of libnm that Fedora uses:
This project could not be compiled on Fedora Rawhide.
Before
After
@tintou I'm not sure if we need to fix the problem or if it's a bug in the bindings for Vala. What do you think?