Fix logic if device is up to date #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cassidyjames would be nice if you can try if this works for you too 😃 |
|
@elementary/ux should a device that can be updated show the current version of the firmware or the version that can be installed? 🤔 |
|
I would think the available version, but I don't know—I could also see a format like |
|
|
cassidyjames
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The port to libfwupd has introduced a regression related to the logic of whether a device is up to date.
Before
After
In both cases, "Unifying Receiver" is at version RQR12.07_B0029 which is lower than the latest release RQR12.10_B0032.