Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a sound for urgent notifications #11

Closed
wants to merge 2 commits into from
Closed

Add a sound for urgent notifications #11

wants to merge 2 commits into from

Conversation

meisenzahl
Copy link
Member

@meisenzahl meisenzahl mentioned this pull request Oct 23, 2020
Merged
marbetschar
marbetschar approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@marbetschar marbetschar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, so its a 👍 from my end. Maybe someone from @elementary/ux wants review this as well before we merge it.

@danirabbit
Copy link
Member

Sorry for taking so long to review! The sound is good for me, but the name doesn't appear to be in the fd.o draft spec: http://0pointer.de/public/sound-naming-spec.html

It looks like the fd.o sound them uses dialog-warning and symlinks dialog-error to it. We should probably do the same

@danirabbit
Copy link
Member

It looks like according to their license they also require attribution in the README

@danirabbit danirabbit mentioned this pull request Jun 15, 2021
Merged
@danirabbit
Copy link
Member

merged with changes in #12

@danirabbit danirabbit closed this Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marbetschar marbetschar marbetschar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meisenzahl @danirabbit @marbetschar