Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port SettingsDaemon.Application to Gtk.Application #81

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

Marukesu
Copy link
Contributor

Gtk.Application has session registration capabilities already, so let's use it.

While here, add the IS_SERVICE and ALLOW_REPLACEMENT flags to the application, so we don't need to implement activate() and have a way to replace the running session during development.

the setup_accounts_services() method was also rewritten to not call org.freedesktop.Accounts.FindUserByName excessively.

Gtk.Application has session registration capabilities already, so let's use it.

while here, add the IS_SERVICE and ALLOW_REPLACEMENT flags to the application,
so we don't need to implement activate() and have a way to replace the running
session during development. the setup_accounts_services() method was also
rewritten to not call org.freedesktop.Accounts.FindUserByName excessively.

Signed-off-by: Gustavo Marques <pushstarttocontinue@outlook.com>
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@danirabbit danirabbit merged commit 6b44f9f into master Aug 1, 2023
4 checks passed
@danirabbit danirabbit deleted the maru/gapplication branch August 1, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants