Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SystemUpdate: make sure we notify if network is metered #164

Merged
merged 3 commits into from
Oct 11, 2024
Merged

SystemUpdate: make sure we notify if network is metered #164

merged 3 commits into from
Oct 11, 2024
+5 −2

Conversation

danirabbit
Copy link
Member

We don't install updates automatically on a metered network even if auto updates is turned on so make sure we notify

@danirabbit danirabbit requested a review from a team October 8, 2024 17:55
zeebok
zeebok approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good! Should we even be searching for updates in the background on a metered connection?

@danirabbit
Copy link
Member Author

@zeebok I think it makes sense to still notify. But I suppose we could use feedback from someone on a metered connection about it

@danirabbit danirabbit merged commit 6e9dd0c into main Oct 11, 2024
4 checks passed
@danirabbit danirabbit deleted the danirabbit/notify-if-metered branch October 11, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @zeebok