Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daemon: Port to GTK4 #1964

Merged
merged 18 commits into from
Jul 5, 2024
Merged

Daemon: Port to GTK4 #1964

merged 18 commits into from
Jul 5, 2024

Conversation

leolost2605
Copy link
Member

Fixes #1696
Fixes #1695

@leolost2605 leolost2605 closed this Jul 2, 2024
@leolost2605 leolost2605 reopened this Jul 2, 2024
@leolost2605 leolost2605 marked this pull request as draft July 2, 2024 09:21
@leolost2605 leolost2605 force-pushed the leolost/daemon-gtk4 branch from 2dca7b0 to 58138c6 Compare July 3, 2024 15:12
@leolost2605 leolost2605 marked this pull request as ready for review July 3, 2024 15:15
@leolost2605 leolost2605 requested a review from a team July 3, 2024 15:16
danirabbit
danirabbit reviewed Jul 3, 2024
View reviewed changes
daemon/WindowMenu.vala Show resolved Hide resolved
meson.build Outdated Show resolved Hide resolved
danirabbit
danirabbit approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the menu position is a little offset on X11 but otherwise works exactly as expected. Nice job!

@leolost2605
Copy link
Member Author

Oh right X is a thing oops 😅
I think monitor labels won't work at all on X :(
Maybe we should keep the gtk3 version as legacy and depending on wayland or x launch the right one? Shouldn't be a maintenance burden since we probably don't have to fix anything there? And we always can just drop it 🤷

@leolost2605 leolost2605 marked this pull request as draft July 4, 2024 11:50
@danirabbit
Copy link
Member

@leolost2605 that makes sense to me! If that's not too much trouble for you

@leolost2605 leolost2605 marked this pull request as ready for review July 5, 2024 14:21
@leolost2605 leolost2605 requested a review from danirabbit July 5, 2024 14:21
@leolost2605
Copy link
Member Author

@danirabbit done!

danirabbit
danirabbit approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🚀

@danirabbit danirabbit merged commit 3a81898 into master Jul 5, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the leolost/daemon-gtk4 branch July 5, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Window context menu doesn't automatically close on Wayland No context menu on wallpaper in Wayland
2 participants
@leolost2605 @danirabbit