Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gtk4 Prep #271

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Gtk4 Prep #271

merged 5 commits into from
Jul 1, 2024

Conversation

danirabbit
Copy link
Member

Backports from #200
Can be rebase merged

Application

  • Rename CSS file. It will be automatically loaded with Granite.init
  • Can't do geometry hints
  • Can't set window position
  • bind maximize here

MainWindow:

  • replace gtk.current_event_time with Gdk.CURRENT_TIME
  • Use child property
  • Code style
  • explicit margins

CameraView:

  • Rename main_widget to stack so it's clear what this widget is
  • Organize
  • Dialog uses present/response not run

TimerButton:

  • Construct with a box since we can't do always_show_image in gtk4
  • Organize
  • Fix icon being misaligned

@danirabbit danirabbit requested a review from a team June 29, 2024 18:00
@zeebok zeebok merged commit 457dcff into master Jul 1, 2024
3 checks passed
@zeebok zeebok deleted the danirabbit/gtk4-prep branch July 1, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants