Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take photo or video on secondary click #204

Merged
merged 16 commits into from
Feb 3, 2022

Conversation

meisenzahl
Copy link
Member

Closes #55

Does exactly what the title says. Hdy.WindowHandle had to be removed to prevent that a secondary click on the camera view opens the secondary window context menu.

Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected - just a couple of minor comments.

Running the base handler after emitting a signal (which is not in an Idle) looks risky but no adverse effect was noticed in practice

src/MainWindow.vala Outdated Show resolved Hide resolved
src/MainWindow.vala Show resolved Hide resolved
@meisenzahl meisenzahl requested a review from jeremypw December 13, 2021 18:26
@cassidyjames cassidyjames added the Needs Design Waiting for input from the UX team label Dec 13, 2021
@cassidyjames cassidyjames requested a review from a team December 13, 2021 18:29
@jeremypw jeremypw dismissed their stale review December 15, 2021 12:08

Changes made

Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functionality lgtm. Leaving for UX input.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the window handle completely here means that the window can no longer be moved at all.

I'm also kind of -1 on trading the window handle for right click here. It seems like being able to move the window by dragging anywhere is more useful than taking a photo with a secondary click, which I'm not sure it makes sense to expect that a secondary click to preform an action

@meisenzahl
Copy link
Member Author

@danrabbit I found a solution so you can take a photo or video on secondary click and we can use a Hdy.WindowHandle. Sorry I didn't think of it sooner.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! just one small comment

src/MainWindow.vala Outdated Show resolved Hide resolved
Co-authored-by: Danielle Foré <daniel@elementary.io>
@danirabbit danirabbit enabled auto-merge (squash) February 3, 2022 06:42
@danirabbit danirabbit merged commit 19a9c09 into master Feb 3, 2022
@danirabbit danirabbit deleted the take-photo-or-video-on-secondary-click branch February 3, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Waiting for input from the UX team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right-click the preview to capture
4 participants