-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take photo or video on secondary click #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected - just a couple of minor comments.
Running the base handler after emitting a signal (which is not in an Idle) looks risky but no adverse effect was noticed in practice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functionality lgtm. Leaving for UX input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the window handle completely here means that the window can no longer be moved at all.
I'm also kind of -1 on trading the window handle for right click here. It seems like being able to move the window by dragging anywhere is more useful than taking a photo with a secondary click, which I'm not sure it makes sense to expect that a secondary click to preform an action
… clicking on camera view
@danrabbit I found a solution so you can take a photo or video on secondary click and we can use a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! just one small comment
Co-authored-by: Danielle Foré <daniel@elementary.io>
Closes #55
Does exactly what the title says.
Hdy.WindowHandle
had to be removed to prevent that a secondary click on the camera view opens the secondary window context menu.