Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : toc link overflow #15276

Merged
merged 2 commits into from
Feb 4, 2024
Merged

fix : toc link overflow #15276

merged 2 commits into from
Feb 4, 2024

Conversation

heygsc
Copy link
Contributor

@heygsc heygsc commented Dec 26, 2023 •
edited
Loading

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.
image Exceeding parts, text cannot be displayed

@pull-request-triage Pull Request Triage
Copy link

👋 @heygsc, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Dec 26, 2023
@github-actions GitHub Actions
Copy link

Hello @heygsc, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 26, 2023 •
edited
Loading

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Dec 26, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 26, 2023 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=15276
Please comment the example via this playground if needed.

@heygsc heygsc marked this pull request as draft December 26, 2023 11:45
@heygsc heygsc removed their assignment Dec 26, 2023
@heygsc heygsc marked this pull request as ready for review December 26, 2023 11:46
@btea
Copy link
Member

btea commented Jan 3, 2024

The default style of the li tag needs to be adjusted.
image

@heygsc heygsc requested a review from btea January 3, 2024 11:51
@heygsc
Copy link
Contributor Author

heygsc commented Jan 3, 2024

@btea What do I need to do more for this pr? Or just waiting for merge?

@btea
Copy link
Member

btea commented Jan 3, 2024

You don't need to do anything now, just wait for another member to review it.

@heygsc heygsc mentioned this pull request Jan 27, 2024
Merged
3 tasks
@tolking tolking merged commit 3c36473 into element-plus:dev Feb 4, 2024
8 checks passed
@element-bot element-bot mentioned this pull request Feb 18, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@tolking tolking tolking approved these changes

@ryuhangyeong ryuhangyeong Awaiting requested review from ryuhangyeong

@kooriookami kooriookami Awaiting requested review from kooriookami

Assignees
No one assigned
Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heygsc @btea @tolking