Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sliding Sync: Update filters to be robust against remote invite rooms #17450

Merged
merged 51 commits into from
Jul 30, 2024
Merged

Sliding Sync: Update filters to be robust against remote invite rooms #17450

merged 51 commits into from
Jul 30, 2024

Commits on Jul 15, 2024

  1. Make filters.is_encrypted robust to remote invites

    @MadLittleMods
    MadLittleMods committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    3a6eec1 View commit details
    Browse the repository at this point in the history

  2. Try share work

    @MadLittleMods
    MadLittleMods committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    7f72d80 View commit details
    Browse the repository at this point in the history

  3. More robust

    @MadLittleMods
    MadLittleMods committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    18ec437 View commit details
    Browse the repository at this point in the history

  4. Fix lints

    @MadLittleMods
    MadLittleMods committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    a67157e View commit details
    Browse the repository at this point in the history

  5. Return bool from db

    @MadLittleMods
    MadLittleMods committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    ffb61cf View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Add tests

    @MadLittleMods
    MadLittleMods committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9b77c97 View commit details
    Browse the repository at this point in the history

  2. Standardize

    @MadLittleMods
    MadLittleMods committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d609205 View commit details
    Browse the repository at this point in the history

  3. Add TODO for more tests

    @MadLittleMods
    MadLittleMods committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    8ca8ae5 View commit details
    Browse the repository at this point in the history

  4. Add changelog

    @MadLittleMods
    MadLittleMods committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4f50054 View commit details
    Browse the repository at this point in the history

  5. Invalidate caches

    @MadLittleMods
    MadLittleMods committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7ae2425 View commit details
    Browse the repository at this point in the history

  6. Use ROOM_UNKNOWN_SENTINEL

    @MadLittleMods
    MadLittleMods committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b35a2da View commit details
    Browse the repository at this point in the history

  7. Iterate on sentinels

    @MadLittleMods
    MadLittleMods committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4bb34d3 View commit details
    Browse the repository at this point in the history

  8. Simply sentinel for now

    @MadLittleMods
    MadLittleMods committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a07ee22 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'develop' into madlittlemods/robust-remote-invite-filters

    @MadLittleMods
    MadLittleMods committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2c9ec61 View commit details
    Browse the repository at this point in the history

  10. fetch -> get

    @MadLittleMods
    MadLittleMods committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    27a97a0 View commit details
    Browse the repository at this point in the history

  11. Update comments

    @MadLittleMods
    MadLittleMods committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    517bfc4 View commit details
    Browse the repository at this point in the history

  12. Fix typo

    @MadLittleMods
    MadLittleMods committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d22bae4 View commit details
    Browse the repository at this point in the history

  13. Better docstring

    @MadLittleMods
    MadLittleMods committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    8624fb0 View commit details
    Browse the repository at this point in the history

  14. Use constants

    @MadLittleMods
    MadLittleMods committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a77b70e View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Prefer not implementing if not used 

    See #17450 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    df5093b View commit details
    Browse the repository at this point in the history

  2. Separate to its own function (_bulk_get_stripped_state_for_rooms ->… 

    … `_bulk_get_stripped_state_for_rooms_from_sync_room_map`)

See #17450 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    7c33c83 View commit details
    Browse the repository at this point in the history

  3. Use StateMap 

    See #17450 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    474b480 View commit details
    Browse the repository at this point in the history

  4. Fix function name in assertion message

    @MadLittleMods
    MadLittleMods committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    82fa037 View commit details
    Browse the repository at this point in the history

  5. Add tests for when the server leaves the room 

    See #17450 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    6f05bb3 View commit details
    Browse the repository at this point in the history

  6. Ideally, not just current state 

    See #17450 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    d4c4de1 View commit details
    Browse the repository at this point in the history

  7. Add test_filter_encrypted_after_we_left

    @MadLittleMods
    MadLittleMods committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    0ace82d View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Try get server left rooms (not working)

    @MadLittleMods
    MadLittleMods committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    8c97eaa View commit details
    Browse the repository at this point in the history

  2. Implement is_local_host_in_rooms(...)

    @MadLittleMods
    MadLittleMods committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    8dd5a47 View commit details
    Browse the repository at this point in the history

  3. Start of join room_stats_current

    @MadLittleMods
    MadLittleMods committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5267b03 View commit details
    Browse the repository at this point in the history

  4. Working room_stats_state joined by `room_stats_current.local_users_… 

    …in_room > 0`
    @MadLittleMods
    MadLittleMods committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    329bf09 View commit details
    Browse the repository at this point in the history

  5. Add corresponding tests for filter.room_types

    @MadLittleMods
    MadLittleMods committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d7dcbfd View commit details
    Browse the repository at this point in the history

  6. Fix some lints

    @MadLittleMods
    MadLittleMods committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    60ec4e3 View commit details
    Browse the repository at this point in the history

  7. Fix lints

    @MadLittleMods
    MadLittleMods committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    affee22 View commit details
    Browse the repository at this point in the history

  8. Explain why we join tables

    @MadLittleMods
    MadLittleMods committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    8ee1708 View commit details
    Browse the repository at this point in the history

  9. Use StrippedStateEvent type in tests

    @MadLittleMods
    MadLittleMods committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    fe2d84b View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Prefer f-string 

    See #17450 (comment),
#17450 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    4ae3079 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Add `_bulk_get_partial_current_state_content_for_rooms_from_sync_room… 

    …_map`
    @MadLittleMods
    MadLittleMods committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    05bbcb0 View commit details
    Browse the repository at this point in the history

  2. Simplify and share

    @MadLittleMods
    MadLittleMods committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    376d900 View commit details
    Browse the repository at this point in the history

  3. Remove unused methods

    @MadLittleMods
    MadLittleMods committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    28a36e8 View commit details
    Browse the repository at this point in the history

  4. Maybe current state in the future

    @MadLittleMods
    MadLittleMods committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    ac7ca67 View commit details
    Browse the repository at this point in the history

  5. Fix cache busting

    @MadLittleMods
    MadLittleMods committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    15e157e View commit details
    Browse the repository at this point in the history

  6. Fix lints

    @MadLittleMods
    MadLittleMods committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    19968e1 View commit details
    Browse the repository at this point in the history

  7. Shorten name

    @MadLittleMods
    MadLittleMods committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8f5e4bf View commit details
    Browse the repository at this point in the history

  8. Reconsider all stripped events

    @MadLittleMods
    MadLittleMods committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    3c144b3 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'develop' into madlittlemods/robust-remote-invite-filters 

    Conflicts:
	synapse/handlers/sliding_sync.py
    @MadLittleMods
    MadLittleMods committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f3b4c9f View commit details
    Browse the repository at this point in the history

  10. Prefer cache invalidation helper 

    See #17450 (comment)

This allows us to get rid of the type ignore comments and standardize
    @MadLittleMods
    MadLittleMods committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1732b02 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Merge branch 'develop' into madlittlemods/robust-remote-invite-filters 

    Conflicts:
	synapse/handlers/sliding_sync.py
    @MadLittleMods
    MadLittleMods committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    20902e6 View commit details
    Browse the repository at this point in the history

  2. Go back to dedicated room_stats_state lookups 

    See #17450 (comment)
    @MadLittleMods
    MadLittleMods committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    e9b76cc View commit details
    Browse the repository at this point in the history

  3. Update cache busting

    @MadLittleMods
    MadLittleMods committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    484007e View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Prefer assert_never 

    Co-authored-by: Erik Johnston <erikj@element.io>
    @MadLittleMods @erikjohnston
    MadLittleMods and erikjohnston committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7acb1ad View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into madlittlemods/robust-remote-invite-filters 

    Conflicts:
	synapse/handlers/sliding_sync.py
    @MadLittleMods
    MadLittleMods committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    45ed4ce View commit details
    Browse the repository at this point in the history