Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Room upgrade: Use the server_name parameter when joining the new room #3204

Closed
manuroe opened this issue Jul 4, 2019 · 1 comment · Fixed by #3215
Closed

Room upgrade: Use the server_name parameter when joining the new room #3204

manuroe opened this issue Jul 4, 2019 · 1 comment · Fixed by #3215
Labels
feature:room-upgrade feature P1 parity-with-web
Milestone
Sprint 22

Comments

@manuroe
Copy link
Member

manuroe commented Jul 4, 2019

The client just needs to send a server_name alongside the join call to the new room. Convention is to use the tombstone event sender's server name.

Web PR: matrix-org/matrix-react-sdk#3159

Discussion: https://matrix.to/#/!zVpPeWAObqutioiNzB:jki.re/$cKuuTGJdMD9lVWAUDRl9Tln1Ol1APbwJO1G6C2HtO6U?via=matrix.org&via=librepush.net&via=sw1v.org

iOS issue: element-hq/element-ios#2550
@manuroe manuroe modified the milestones: Sprint 21, Sprint 22 Jul 4, 2019
@manuroe
Copy link
Member Author

manuroe commented Jul 8, 2019

This will fix #3186.

bmarty added a commit to matrix-org/matrix-android-sdk that referenced this issue Jul 17, 2019
@bmarty
Add "server_name" parameter to the join room request (element-hq/riot…
2977fbc 
…-android#3204)
@bmarty bmarty mentioned this issue Jul 17, 2019
Merged
3 tasks
bmarty added a commit that referenced this issue Jul 17, 2019
@bmarty
Room upgrade: Use the server_name parameter when joining the new ro…
039173e 
…om (Fixes #3204)
@bmarty bmarty mentioned this issue Jul 17, 2019
Merged
This was referenced Jul 22, 2019
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature:room-upgrade feature P1 parity-with-web
Projects
None yet
Milestone
Sprint 22
Development

Successfully merging a pull request may close this issue.

Room upgrade: Use the server_name parameter when joining the new room element-hq/riot-android
1 participant
@manuroe