Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable message pinning labs by default #25

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Enable message pinning labs by default #25

merged 1 commit into from
Sep 11, 2024

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Sep 11, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Enable the feature by default to have more feedbacks from nightly and develop users.
In the next RC, feature pinning will go out of labs #22

@florianduros florianduros added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Sep 11, 2024
@florianduros florianduros force-pushed the florianduros/pinned-messages/default-true branch from 1338a6d to 789ce6d Compare September 11, 2024 08:43
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@florianduros florianduros marked this pull request as ready for review September 11, 2024 09:25
@florianduros florianduros requested a review from a team as a code owner September 11, 2024 09:25
dbkr
dbkr approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

daniellekirkwood
daniellekirkwood approved these changes Sep 11, 2024
View reviewed changes
Copy link

@daniellekirkwood daniellekirkwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Excited to have develop and nightly users see this feature automatically ahead of launch!

@florianduros florianduros added this pull request to the merge queue Sep 11, 2024
Merged via the queue into develop with commit 03004a5 Sep 11, 2024
27 checks passed
@florianduros florianduros deleted the florianduros/pinned-messages/default-true branch September 11, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@daniellekirkwood daniellekirkwood daniellekirkwood approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florianduros @dbkr @daniellekirkwood