This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Fix vertical overflow on the mobile register screen #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ton can be scrolled fully in to view.
florianduros
approved these changes
Oct 9, 2024
|
(this might have been a dynamic type induced thing - i suspect the text sizing was set to minimum on the screen) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR
It fixes a bug whereby the mobile register screen could not be scrolled at small resolutions. I think this is wasn't caught before, as generally the mobile screen sizes are big enough to render this.
Before (can't scroll)
Screen.Recording.2024-10-09.at.15.39.52.mov
After
Screen.Recording.2024-10-09.at.15.41.14.mov