Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send UTD occurences to Posthog #2575

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Send UTD occurences to Posthog #2575

merged 3 commits into from
Mar 14, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Mar 14, 2024

this uses UTD tracking to allow better logging of any UTD issues and send them to posthog. Also bumps the SDK to version 1.1.50

@Velin92 Velin92 requested a review from a team as a code owner March 14, 2024 15:11
@Velin92 Velin92 requested review from pixlwave and removed request for a team March 14, 2024 15:11
@Velin92 Velin92 force-pushed the stefan/utdTracking branch from cebe0e7 to fb4fa52 Compare March 14, 2024 15:14
Copy link

github-actions bot commented Mar 14, 2024

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️

ElementX/Sources/Services/Client/ClientProxy.swift#L172 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

⚠️

ElementX/Sources/Services/Client/ClientProxy.swift#L174 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

⚠️

ElementX/Sources/Services/Client/ClientProxy.swift#L176 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

Generated by 🚫 Danger Swift against 94ebe4b

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although there are conflicts from my updating the analytics package earlier to send the moderation event.

@Velin92 Velin92 force-pushed the stefan/utdTracking branch from f9ad5bd to 94ebe4b Compare March 14, 2024 18:26
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Velin92 Velin92 enabled auto-merge (squash) March 14, 2024 18:27
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 74.56%. Comparing base (d2a9db8) to head (94ebe4b).
Report is 1 commits behind head on develop.

Files Patch % Lines
.../FlowCoordinators/UserSessionFlowCoordinator.swift 0.00% 18 Missing ⚠️
.../Sources/Services/Analytics/AnalyticsService.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2575      +/-   ##
===========================================
- Coverage    74.70%   74.56%   -0.14%     
===========================================
  Files          553      554       +1     
  Lines        38134    38225      +91     
  Branches     17337    17335       -2     
===========================================
+ Hits         28489    28504      +15     
- Misses        9645     9721      +76     
Flag Coverage Δ
unittests 60.82% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants