Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider that the topic of a room has been removed when it's blank. #4209

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 28, 2025

Content

Motivation and context

Closes #4206

Screenshots / GIFs

image

Tests

  • In a room, set the topic to ""
  • observe the rendering on the timeline.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner January 28, 2025 15:09
@bmarty bmarty requested review from ganfra and removed request for a team January 28, 2025 15:09
@bmarty bmarty added the PR-Misc For other changes label Jan 28, 2025
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/7MTAhT

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.19%. Comparing base (ebfb47e) to head (3a6ba44).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4209   +/-   ##
========================================
  Coverage    80.19%   80.19%           
========================================
  Files         2022     2022           
  Lines        53271    53271           
  Branches      6443     6443           
========================================
  Hits         42723    42723           
  Misses        8330     8330           
  Partials      2218     2218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 5068b91 into develop Jan 28, 2025
30 checks passed
@bmarty bmarty deleted the feature/bma/roomTopic branch January 28, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Show a blank topic as removed in the state event.
2 participants