Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design) : update send button background #4000

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Dec 5, 2024

Content

Update the send button background colors.

Motivation and context

https://www.figma.com/design/Ni6Ii8YKtmXCKYNE90cC67/Timeline-(new)?node-id=2274-39944&m=dev

Screenshots / GIFs

See recorded screenshots.

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added PR-Change For updates to an existing feature Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. labels Dec 5, 2024
@ganfra ganfra marked this pull request as ready for review December 5, 2024 15:56
@ganfra ganfra requested a review from a team as a code owner December 5, 2024 15:56
@ganfra ganfra requested review from bmarty and removed request for a team December 5, 2024 15:56
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 5, 2024
@ganfra ganfra added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/5zi6sV

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.09%. Comparing base (f3ee89d) to head (2cddb32).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4000      +/-   ##
===========================================
- Coverage    83.09%   83.09%   -0.01%     
===========================================
  Files         1808     1808              
  Lines        45887    45878       -9     
  Branches      5395     5395              
===========================================
- Hits         38131    38122       -9     
  Misses        5862     5862              
  Partials      1894     1894              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra force-pushed the feature/fga/send_button_update branch from 1025c94 to 2cddb32 Compare December 5, 2024 16:24
Copy link

sonarqubecloud bot commented Dec 5, 2024

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 5, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 5, 2024
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this.

@ganfra ganfra enabled auto-merge December 5, 2024 16:58
@ganfra ganfra merged commit 317931d into develop Dec 5, 2024
30 checks passed
@ganfra ganfra deleted the feature/fga/send_button_update branch December 5, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants