Try fixing tests

element-hq · Oct 10, 2024 · 1ef1ca2 · 1ef1ca2
1 parent e49a838
commit 1ef1ca2
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/...tlin/io/element/android/features/invite/impl/response/AcceptDeclineInvitePresenterTest.kt b/...tlin/io/element/android/features/invite/impl/response/AcceptDeclineInvitePresenterTest.kt
@@ -99,7 +99,7 @@ class AcceptDeclineInvitePresenterTest {
                     InternalAcceptDeclineInviteEvents.ConfirmDeclineInvite
                 )
             }
-            skipItems(1)
+            skipItems(2)
             awaitItem().also { state ->
                 assertThat(state.declineAction).isInstanceOf(AsyncAction.Failure::class.java)
                 state.eventSink(
@@ -147,7 +147,7 @@ class AcceptDeclineInvitePresenterTest {
                     InternalAcceptDeclineInviteEvents.ConfirmDeclineInvite
                 )
             }
-            skipItems(1)
+            skipItems(2)
             awaitItem().also { state ->
                 assertThat(state.declineAction).isInstanceOf(AsyncAction.Success::class.java)
             }

diff --git a/...m/impl/src/test/kotlin/io/element/android/features/joinroom/impl/JoinRoomPresenterTest.kt b/...m/impl/src/test/kotlin/io/element/android/features/joinroom/impl/JoinRoomPresenterTest.kt
@@ -338,11 +338,15 @@ class JoinRoomPresenterTest {
             awaitItem().also { state ->
                 state.eventSink(JoinRoomEvents.KnockRoom)
             }
+
+            assertThat(awaitItem().knockAction).isEqualTo(AsyncAction.Loading)
             awaitItem().also { state ->
                 assertThat(state.knockAction).isEqualTo(AsyncAction.Success(Unit))
                 fakeKnockRoom.lambda = knockRoomFailure
                 state.eventSink(JoinRoomEvents.KnockRoom)
             }
+
+            assertThat(awaitItem().knockAction).isEqualTo(AsyncAction.Loading)
             awaitItem().also { state ->
                 assertThat(state.knockAction).isInstanceOf(AsyncAction.Failure::class.java)
             }

diff --git a/...t/kotlin/io/element/android/features/verifysession/impl/VerifySelfSessionPresenterTest.kt b/...t/kotlin/io/element/android/features/verifysession/impl/VerifySelfSessionPresenterTest.kt
@@ -343,6 +343,7 @@ class VerifySelfSessionPresenterTest {
             skipItems(1)
             val initialItem = awaitItem()
             initialItem.eventSink(VerifySelfSessionViewEvents.SignOut)
+            assertThat(awaitItem().signOutAction.isLoading()).isTrue()
             val finalItem = awaitItem()
             assertThat(finalItem.signOutAction.isSuccess()).isTrue()
             assertThat(finalItem.signOutAction.dataOrNull()).isEqualTo("aUrl")

diff --git a/.../impl/src/main/kotlin/io/element/android/libraries/roomselect/impl/RoomSelectPresenter.kt b/.../impl/src/main/kotlin/io/element/android/libraries/roomselect/impl/RoomSelectPresenter.kt
@@ -52,7 +52,7 @@ class RoomSelectPresenter @AssistedInject constructor(
 
         val roomSummaryDetailsList by dataSource.roomInfoList.collectAsState(initial = persistentListOf())
 
-        val searchResults by remember<State<SearchBarResultState<ImmutableList<RoomSummary>>>> {
+        val searchResults by remember<State<SearchBarResultState<ImmutableList<SelectRoomInfo>>>> {
             derivedStateOf {
                 when {
                     roomSummaryDetailsList.isNotEmpty() -> SearchBarResultState.Results(roomSummaryDetailsList.toImmutableList())