-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FTUE onboarding as it is incompatible with SSO/OIDC #28943
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no particular attachment to this screen, but the linked issue doesn't obviously come to the conclusion to kill it? We must be able to differentiate new logins from new registrations as I thought we use that to decide whether to set up cross signing or not?
The conclusion to the issue came in a call today between @pmaier1 & @daniellekirkwood - we may revisit similar onboarding next year, for now we did not wish to pursue the spec work & backend work necessary for the server to signal new vs existing account to the client. |
Is that actually the case? That would certainly be a blocker. I would have thought we'd just use the cross-signing state to decide whether to set it up or not (like, if it's not set up yet, set it up)? |
Just checked and apparently I was wrong: we set up cross signing on any new registration or login. Would it be worth a quick note on that issue to say where this was decided, just so we all remember? |
Fixes #26025