Implement new memberlist design with MVVM architecture #28874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Use MemberInfo instead of RoomMember 2. CSS changes to reflect the new design
We used the EntityTile component as a pretend overflow tile in some places. This new lighter component is added so that we can remove the complex EntityTile component.
MidhunSureshR
commented
Jan 6, 2025
There was a problem hiding this comment.
This component must be retained since it's used in multiple other places.
There was a problem hiding this comment.
PresenceLabel component must still be retained since it's used in UserInfo
There was a problem hiding this comment.
We were using EntityTile to create a sort of overflow tile. Adding this much simpler component will allow us to remove EntityTile for good.
MidhunSureshR
force-pushed
the
midhun/memberlist-redesign
branch
from
c6cd3cf to
ec78793
Compare
MidhunSureshR
force-pushed
the
midhun/memberlist-redesign
branch
from
ede94c2 to
58f5d9b
Compare
MidhunSureshR
force-pushed
the
midhun/memberlist-redesign
branch
from
58f5d9b to
37a6d09
Compare
MidhunSureshR
force-pushed
the
midhun/memberlist-redesign
branch
from
8e8a5cb to
2bf96cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/element-hq/wat-internal/issues/224
Implements MVVM architecture where the view is a react component that depends on the view-model. The view model is implemented as custom react hooks.