Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Element Call by default on release instances #28313

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 28, 2024

Update button label to say it is a Beta

For https://github.com/element-hq/element-internal/issues/638

Update button label to say it is a Beta

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@neilisfragile
Copy link
Member

Channelling @kongo09 (and @daniellekirkwood) This change has Product sign-off.

@t3chguy t3chguy added the backport staging Label to automatically backport PR to staging branch label Oct 28, 2024
@t3chguy t3chguy enabled auto-merge October 28, 2024 14:22
@t3chguy t3chguy added this pull request to the merge queue Oct 28, 2024
Merged via the queue into develop with commit 79c9563 Oct 28, 2024
50 checks passed
@t3chguy t3chguy deleted the t3chguy/enable-ec branch October 28, 2024 15:39
@RiotRobot
Copy link
Contributor

The backport to staging failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-staging staging
# Navigate to the new working tree
cd .worktrees/backport-staging
# Create a new branch
git switch --create backport-28313-to-staging
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 79c956388f4b4e0feb15d6bc9c4ceabcfb7b9839
# Push it to GitHub
git push --set-upstream origin backport-28313-to-staging
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-staging

Then, create a pull request where the base branch is staging and the compare/head branch is backport-28313-to-staging.

t3chguy added a commit that referenced this pull request Oct 28, 2024
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

(cherry picked from commit 79c9563)
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@daniellekirkwood
Copy link
Contributor

Thanks @neilisfragile -- is it possible to get click tracking added for these buttons? It would be awesome to understand if we need to do more education on it or if people grok the selection really quickly...
@t3chguy would you be able to add this? Should I write a ticket for you?

@t3chguy
Copy link
Member Author

t3chguy commented Oct 28, 2024

Not possible for tomorrow only for the release after if it is reviewed in time (unlikely given time constraints) so it'd be for the release after that (Nov 19th). Due to the repo merge we can't make matrix-react-sdk changes for the off cycle.

@neilisfragile
Copy link
Member

Off topic, but another option for the future if the buttons are too confusing is to have a single button and have EW make both legacy and MatrixRTC calls in parallel, if either call is accepted then the other one can be hung up.

I think this idea still needs some thinking about how to handle races etc, but mentioning here for context as an alternative option if the two button approach is detrimental.

@t3chguy
Copy link
Member Author

t3chguy commented Oct 29, 2024

@neilisfragile not sure that'd help with the Jitsi vs Element Call variant of the problem

@neilisfragile
Copy link
Member

Yeah agreed, only helps for 1:1 calling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport staging Label to automatically backport PR to staging branch T-Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants