Updated the login logo.

[ankur12-1610]

Signed-off-by: ankur12-1610 anknerd.12@gmail.com

Fixes: #20785

Before:

After:

---

This change has no change notes, so will not be included in the changelog.

[ankur12-1610]

@nadonomy could you please review 😅 ?

[SimonBrandner]

Just to check - have you made sure the logo isn't used elsewhere, so that we don't change it in the wrong places?

[ankur12-1610]

Just to check - have you made sure the logo isn't used elsewhere, so that we don't change it in the wrong places?

Yeah, I checked it and I only found element-logo.svg in res/themes/element/img/logos and in the web app which is generated in the build. So I just replaced the previous logo with the new one.

[germain-gg]

element-logo.svg is referenced in 4 components

• CompabilityView.tsx
• ErrorView.tsx
• VectorAuthHeaderLogo.tsx
• HomePage.tsx

To facilitate the review from the deisgn team, could you attach screenshots of those instances in the PR?
Code otherwise looks good

[ankur12-1610]

element-logo.svg is referenced in 4 components

• CompabilityView.tsx
• ErrorView.tsx
• VectorAuthHeaderLogo.tsx
• HomePage.tsx

To facilitate the review from the deisgn team, could you attach screenshots of those instances in the PR? Code otherwise looks good

@gsouquet those instances, in the sense the code snippets?

[germain-gg]

No, taking screenshots of how they look in the product

[ankur12-1610]

No, taking screenshots of how they look in the product

Oh! got it I'll upload them :)

[ankur12-1610]

• CompabilityView

[ankur12-1610]

@gsouquet could you please check?
I'm unsure about the 'url-paths` 😅.

[ankur12-1610]

@gsouquet could you please check? I'm unsure about the 'paths` sweat_smile.

I also changed res/welcome/images/logo.svg as it had previous logo.

[ankur12-1610]

@gsouquet sorry to disturb but can you review the current changes:sweat_smile:

[SimonBrandner]

@gsouquet sorry to disturb but can you review the current changessweat_smile

@gsouquet has already reviewed your PR. Now the PR is awaiting a review from the design team

[ankur12-1610]

@gsouquet sorry to disturb but can you review the current changessweat_smile

@gsouquet has already reviewed your PR. Now the PR is awaiting a review from the design team

Actually, I changed one more file, so I just needed confirmation for that :')

I guess, design team gave an approval 🎉

[SimonBrandner]

@gsouquet sorry to disturb but can you review the current changessweat_smile

@gsouquet has already reviewed your PR. Now the PR is awaiting a review from the design team

Actually, I changed one more file, so I just needed confirmation for that :')

I guess, design team gave an approval tada

I am afraid @AstroOrbis isn't a member of the design team :(

[AstroOrbis]

I'm not haha, I just find the change cool :3 👍🏻

[ankur12-1610]

I'm not haha, I just find the change cool :3 👍🏻

xD

[ankur12-1610]

@gsouquet sorry to disturb but can you review the current changessweat_smile

@gsouquet has already reviewed your PR. Now the PR is awaiting a review from the design team

Actually, I changed one more file, so I just needed confirmation for that :')

I guess, design team gave an approval tada

I am afraid @AstroOrbis isn't a member of the design team :(

😥At what frequency does the design team review the PRS?

[SimonBrandner]

@gsouquet sorry to disturb but can you review the current changessweat_smile

@gsouquet has already reviewed your PR. Now the PR is awaiting a review from the design team

Actually, I changed one more file, so I just needed confirmation for that :')
I guess, design team gave an approval tada

I am afraid @AstroOrbis isn't a member of the design team :(

disappointed_relievedAt what frequency does the design team review the PRS?

It very much depends, often longer time than the code review as the design team is often busy.

@nadonomy, do you want to take a look, as you're the author of the issue?

[ankur12-1610]

Ah! get it, np :)

[JordanConnor]

Looks good to me 👍