Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature_thread #20761

Closed
wants to merge 2 commits into from
Closed

Conversation

eleensmathew
Copy link
Contributor

@eleensmathew eleensmathew commented Jan 26, 2022

Most of the information is from https://github.com/matrix-org/matrix-doc/blob/gsouquet/threading-via-relations/proposals/3440-threading-via-relations.md. Please review and tell me if any changes are to be made.


This PR currently has no changelog labels, so will not be included in changelogs.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

@eleensmathew eleensmathew requested a review from a team as a code owner January 26, 2022 07:31
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening a PR here.
The idea is to document the feature at a very high level so that folks understand roughly what it does.

For this pull request to be merged I would recommend you remove all technical details and write a few lines describing what this does

docs/labs.md Outdated Show resolved Hide resolved
docs/labs.md Outdated Show resolved Hide resolved
@SimonBrandner SimonBrandner requested a review from germain-gg March 1, 2022 19:37
docs/labs.md Outdated Show resolved Hide resolved
@germain-gg
Copy link
Contributor

It looks like this PR needs rebasing too, there's some conflicting file

Co-authored-by: Germain <germain@souquet.com>
@eleensmathew
Copy link
Contributor Author

Hi @gsouquet I changed the file as you suggested, but I opened a new pull request #21303 to fix the issues.

@germain-gg
Copy link
Contributor

Closing in favour of #21303

@germain-gg germain-gg closed this Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants