Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font scaling labs setting. #13199

Conversation

JorikSchellekens
Copy link
Contributor

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'll also need adding to the develop config (which is in-tree, somewhere)

config.sample.json Outdated Show resolved Hide resolved
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also docs in the labs.md please

JorikSchellekens and others added 2 commits April 21, 2020 10:01
Co-Authored-By: Travis Ralston <travpc@gmail.com>
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just needs adding to ~/riot.im/develop/config.json and it's good to go - thanks!

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This side lgtm. The tests are super angry but should be fine - might just need to merge in latest develop.

Merge branch 'develop' of github.com:vector-im/riot-web into joriks/font-sclaing-slider
@JorikSchellekens JorikSchellekens merged commit 6873b48 into element-hq:develop Apr 23, 2020
@JorikSchellekens JorikSchellekens deleted the joriks/font-sclaing-slider branch April 23, 2020 09:30
@turt2live
Copy link
Member

In general we try to not land the docs until the feature has landed as usually people get confused.

@turt2live
Copy link
Member

I'm going to revert this as it's already causing confusion - will have to wait until matrix-org/matrix-react-sdk#4424 can land before going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants