-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update install guide #10810
Update install guide #10810
Conversation
also make button a link 'cos buttons can't have hrefs
Made button update dynamically (I also made it a link instead as buttons can't have hrefs). Other changes look good. |
src/vector/mobile_guide/index.js
Outdated
@@ -92,6 +92,9 @@ async function initPage() { | |||
if (isUrl && !isUrl.endsWith('/')) isUrl += '/'; | |||
|
|||
if (hsUrl !== 'https://matrix.org/') { | |||
document.getElementById('configure_riot_button').href = | |||
"https://riot.im/config/config?hs_url=" + encodeURIComponent(hsUrl) + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configconfig?
"Back to Desktop"? "Back to Riot.im" was already confusing for many users. I'm not really sure what back to desktop even means. It would be really great to say something closer to "Use Riot in my web browser instead (not recommended)", obviously word that better if you can but back to desktop doesn't really make sense. |
Viewed in a vacuum on desktop, I'd agree. However, if we empathise with the journey the user has taken to arrive at this context:
Considering the most prevalent mobile browsers (Safari on iOS & Chrome on Android) use 'Request Desktop Site' I think it's wise to borrow affordance from their nomenclature, albeit dropping 'Site'. |
Back to Desktop Site would be a lot clearer imo |
Although I still don't understand why it is "Back to". They loaded riot.im in their browser and were immediately redirected to this page right? They were never on the desktop site to begin with. |
You're right— "Go to Desktop Site" could be more appropriate, depending on their entry path. |
* OIDC: add delegatedauthentication to validated server config ([\element-hq#11053](matrix-org/matrix-react-sdk#11053)). Contributed by @kerryarchibald. * Allow image pasting in plain mode in RTE ([\element-hq#11056](matrix-org/matrix-react-sdk#11056)). Contributed by @alunturner. * Show room options menu if "UIComponent.roomOptionsMenu" is enabled ([\element-hq#10365](matrix-org/matrix-react-sdk#10365)). Contributed by @maheichyk. * Allow image pasting in rich text mode in RTE ([\element-hq#11049](matrix-org/matrix-react-sdk#11049)). Contributed by @alunturner. * Update voice broadcast redaction to use MSC3912 `with_rel_type` instead of `with_relations` ([\element-hq#11014](matrix-org/matrix-react-sdk#11014)). Fixes element-hq#25471. * Add config to skip widget_build_url for DM rooms ([\element-hq#11044](matrix-org/matrix-react-sdk#11044)). Fixes vector-im/customer-retainer#74. * Inhibit interactions on forward dialog message previews ([\element-hq#11025](matrix-org/matrix-react-sdk#11025)). Fixes element-hq#23459. * Removed `DecryptionFailureBar.tsx` ([\element-hq#11027](matrix-org/matrix-react-sdk#11027)). Fixes element-hq/element-meta#1358. Contributed by @florianduros. * Fix translucent `TextualEvent` on search results panel ([\element-hq#10810](matrix-org/matrix-react-sdk#10810)). Fixes element-hq#25292. Contributed by @luixxiul. * Matrix matrix scheme permalink constructor not stripping query params ([\element-hq#11060](matrix-org/matrix-react-sdk#11060)). Fixes element-hq#25535. * Fix: "manually verify by text" does nothing ([\element-hq#11059](matrix-org/matrix-react-sdk#11059)). Fixes element-hq#25375. Contributed by @kerryarchibald. * Make group calls respect the ICE fallback setting ([\element-hq#11047](matrix-org/matrix-react-sdk#11047)). Fixes vector-im/voip-internal#65. * Align list items on the tooltip to the start ([\element-hq#11041](matrix-org/matrix-react-sdk#11041)). Fixes element-hq#25355. Contributed by @luixxiul. * Clear thread panel event permalink when changing rooms ([\element-hq#11024](matrix-org/matrix-react-sdk#11024)). Fixes element-hq#25484. * Fix spinner placement on pinned widgets being reloaded ([\element-hq#10970](matrix-org/matrix-react-sdk#10970)). Fixes element-hq#25431. Contributed by @luixxiul.
Updated styling to present options clearer and with less scrolling. Removed extraneous copy & elements. Looks like:
& if there's server configuration:
Not merge ready.
configure_riot_button
needs to be dynamically set, using whatever configuration link we arrive at. Ideally this is either a universal link for both iOS & Android, or if not we detect user agent and inject appropriately.