Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riot Web attempts to work too aggressively on mobile #9360

Closed
5 tasks done
nadonomy opened this issue Apr 2, 2019 · 6 comments
Closed
5 tasks done

Riot Web attempts to work too aggressively on mobile #9360

nadonomy opened this issue Apr 2, 2019 · 6 comments
Assignees
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@nadonomy
Copy link
Contributor

nadonomy commented Apr 2, 2019

Related PR: #9363

  • Investigate what's going on
  • Add cookie expiry time
  • Adjust expiry time to 4hrs
  • Cookie expiry set in onBackToRiotClick() doesn't solve the problem for users with the cookie already set. Clear with next release?
  • Make CSS more mobile friendly, so text doesn't render tiny (and update branding along the way)

Notes from internal chat, tested on iPad:

https://matrix.to/#/!tAMgPDeOawUJMkFXVZ:matrix.org/$1553800151544179fppPV:matrix.org?via=matrix.org&via=jki.re&via=dbkr.me

@nadonomy nadonomy added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround P1 🔥 Fire 🔥 labels Apr 2, 2019
@turt2live
Copy link
Member

more info: Sometimes it works, sometimes it doesn't. Tom got no mobile guide, but then at some point in the rageshake process got it suddenly. Seems like 2/5 devices skipped the guide

@turt2live turt2live self-assigned this Apr 2, 2019
@turt2live
Copy link
Member

So both cases of this happening in our standup are actually a feature: #7415 (#7378)

I'll at least open a PR to expire the cookie after 24 hours or so (the page is a bit complicated, so a short TTL is easier than 'make it work for a session'), however the rest I'm leaving to @nadonomy and @lampholder to figure out.

@turt2live turt2live added the X-Needs-Info This issue is blocked awaiting information from the reporter label Apr 2, 2019
turt2live added a commit that referenced this issue Apr 2, 2019
See #9360

This is to prevent it from always working. Cookies without an expiration are supposed to expire at the end of the session, however the nature of mobile browsers means that the session is unlikely to ever end.
@turt2live turt2live added X-Needs-Design X-Needs-Product More input needed from the Product team labels Apr 2, 2019
@turt2live turt2live removed their assignment Apr 2, 2019
@nadonomy
Copy link
Contributor Author

nadonomy commented Apr 3, 2019

I took a look at the PR. I think setting an expiry time on the cookie seems reasonable. A few thoughts on how we can improve fixing this further:

  1. The cookie expiry is set in onBackToRiotClick(), which I assume won't solve the problem for users who already have the cookie set, so we should figure out something for them.
  2. Is an expiry time of 2 or 4hrs more appropriate? It's enough to not be constantly popping up interrupting a session but for continued sessions users should really be using a mobile app.
  3. Whenever I didn't hit the bug the install guide was tiny. I assume somewhere along the app stack meta viewport CSS is erroneously cascading. This is a must fix to consider the issue solved. (All of the install guide CSS is in the head of the doc, so a very low effort fix could be to set it correctly there with !important?)

@lampholder let me know your thoughts.

@nadonomy nadonomy changed the title Riot Web attempts to work on mobile Riot Web attempts to work too aggressively on mobile Apr 3, 2019
@lampholder
Copy link
Member

I remember now our deciding not to show the install instructions on deep links. On reflection I think this is a bit weird, but I think will get some attention when we condsider link-based onboarding in more detail.

In the meantime, if we fix #8384 and make the mobile install instructions dismissable as per @turt2live/@nadonomy's discussion above, I think we'll be back in a reasonable place.

@nadonomy nadonomy removed X-Needs-Design X-Needs-Product More input needed from the Product team X-Needs-Info This issue is blocked awaiting information from the reporter labels Apr 3, 2019
@nadonomy
Copy link
Contributor Author

nadonomy commented Apr 3, 2019

Updated parent comment with a checklist of outstanding stuff before we consider the issue resolved. Feel free to edit/amend/add to it.

@turt2live turt2live self-assigned this Apr 3, 2019
@turt2live
Copy link
Member

@nadonomy I'm not able to reproduce the tiny effect. The guide is a bit on the small side, but it sounds like you're running into a worse problem than that.

Here's what I see:
image

@turt2live turt2live added the X-Needs-Info This issue is blocked awaiting information from the reporter label Apr 4, 2019
@nadonomy nadonomy self-assigned this Apr 4, 2019
@nadonomy nadonomy removed X-Needs-Info This issue is blocked awaiting information from the reporter 🔥 Fire 🔥 labels Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants