-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Riot Web attempts to work too aggressively on mobile #9360
Comments
more info: Sometimes it works, sometimes it doesn't. Tom got no mobile guide, but then at some point in the rageshake process got it suddenly. Seems like 2/5 devices skipped the guide |
So both cases of this happening in our standup are actually a feature: #7415 (#7378) I'll at least open a PR to expire the cookie after 24 hours or so (the page is a bit complicated, so a short TTL is easier than 'make it work for a session'), however the rest I'm leaving to @nadonomy and @lampholder to figure out. |
See #9360 This is to prevent it from always working. Cookies without an expiration are supposed to expire at the end of the session, however the nature of mobile browsers means that the session is unlikely to ever end.
I took a look at the PR. I think setting an expiry time on the cookie seems reasonable. A few thoughts on how we can improve fixing this further:
@lampholder let me know your thoughts. |
I remember now our deciding not to show the install instructions on deep links. On reflection I think this is a bit weird, but I think will get some attention when we condsider link-based onboarding in more detail. In the meantime, if we fix #8384 and make the mobile install instructions dismissable as per @turt2live/@nadonomy's discussion above, I think we'll be back in a reasonable place. |
Updated parent comment with a checklist of outstanding stuff before we consider the issue resolved. Feel free to edit/amend/add to it. |
@nadonomy I'm not able to reproduce the tiny effect. The guide is a bit on the small side, but it sounds like you're running into a worse problem than that. |
Related PR: #9363
onBackToRiotClick()
doesn't solve the problem for users with the cookie already set. Clear with next release?Notes from internal chat, tested on iPad:
https://matrix.to/#/!tAMgPDeOawUJMkFXVZ:matrix.org/$1553800151544179fppPV:matrix.org?via=matrix.org&via=jki.re&via=dbkr.me
The text was updated successfully, but these errors were encountered: