Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of Field refs from RegistrationForm #9172

Closed
jryans opened this issue Mar 14, 2019 · 0 comments
Closed

Remove usage of Field refs from RegistrationForm #9172

jryans opened this issue Mar 14, 2019 · 0 comments
Assignees
@jryans
Labels
A-Authentication

Comments

@jryans
Copy link
Collaborator

jryans commented Mar 14, 2019 •
edited
Loading

RegistrationForm is the last spot to use refs for Field components. We should remove these so there's a consistent usage pattern for Fields.

It also depends on the value getter as well, which I missed as part of matrix-org/matrix-react-sdk#2780.

Once this conversion happens, we can again remove the Field value getter.
@jryans jryans mentioned this issue Mar 14, 2019
Merged
@jryans jryans self-assigned this Mar 14, 2019
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Mar 14, 2019
@jryans
Remove refs from RegistrationForm
ec51aee 
This aligns the code in `RegistrationForm` with other users of the `Field`
component. (In matrix-org#2780, I had
thought that this code would be okay to leave alone, but I had missed the usage
of the `Field` value getter.)

Fixes element-hq/element-web#9172
@jryans jryans mentioned this issue Mar 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Authentication
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jryans