Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin unread rooms unusable on accounts with many rooms #7646

Closed
turt2live opened this issue Nov 1, 2018 · 3 comments
Closed

Pin unread rooms unusable on accounts with many rooms #7646

turt2live opened this issue Nov 1, 2018 · 3 comments
Assignees
@turt2live
Labels
A-Room-List X-Regression

Comments

@turt2live
Copy link
Member

The room list constantly re-sorts itself, freezing Riot every second
@turt2live
Copy link
Member Author

regression of matrix-org/matrix-react-sdk#1936

@turt2live turt2live self-assigned this Nov 1, 2018
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Nov 1, 2018
@turt2live
Avoid hitting the SettingsStore thousands of times when generating ro…
5558b7a 
…om lists

Should fix element-hq/element-web#7646 to some degree
@turt2live turt2live mentioned this issue Nov 1, 2018
Merged
@turt2live
Copy link
Member Author

matrix-org/matrix-react-sdk#2265 fixes the bulk of the issue, but doesn't address a lot of the performance problems when the options are enabled.

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Nov 1, 2018
@turt2live
Improve room list sort performance by caching common variables
0c7aadb 
This won't help much if the user is in a ton of highly active rooms, but for the most part this will help those in thousands of rooms, many of which are likely to be quiet. 

Fixes element-hq/element-web#7646
Fixes element-hq/element-web#7645 (due to timestamp ordering)
@turt2live
Copy link
Member Author

Fixed by matrix-org/matrix-react-sdk#2265

@turt2live turt2live mentioned this issue Dec 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Room-List X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@turt2live