Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable AGC #6278

Closed
TheLastProject opened this issue Mar 4, 2018 · 14 comments · Fixed by matrix-org/matrix-react-sdk#8759
Closed

Option to disable AGC #6278

TheLastProject opened this issue Mar 4, 2018 · 14 comments · Fixed by matrix-org/matrix-react-sdk#8759
Labels
A-VoIP O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Enhancement

Comments

@TheLastProject
Copy link
Contributor

Description

Automatic Gain Control keeps increasing my recording volume constantly, despite it causing the volume to clip. This is rather annoying and it took me ages to find out what was even causing it (apparently it's a Chromium feature)

Steps to reproduce

  • Have a voice or video call
  • Notice recording volume rising at random points

Log: not sent

Version information

  • Platform: web
  • OS: Fedora 27
  • Version: 0.13.5

#4634 seems to be related, but I only ever do one-on-one chats so haven't experienced it in conference calls.
@lampholder
Copy link
Member

Do you know if this is possible to do in Chrome/Chromium?

From my 30 seconds of searching it looks like disabling AGC is supported in Firefox but maybe not elsewhere?

@lampholder lampholder added feature X-Needs-Info This issue is blocked awaiting information from the reporter A-VoIP labels Mar 6, 2018
@jkalousek
Copy link
Contributor

jkalousek commented Mar 26, 2019 •
edited
Loading

As this is still a problem I searched and in Chorme's "chrome://flags/" I found flag for "WebRTC hybrid Agc2/Agc1" and there is also "WebRTC Echo Canceller 3" which might be good option to be able to disable. Can these options be utilized?

EDIT: I'm referring mostly to option to be able to disable this in desktop (Win) version of Riot.

@darkmattercoder
Copy link

Any status update? I did my first matrix audio conference a few days ago, and everything went to shit because the auto gain constantly changed the mic level.

@dingodoppelt
Copy link

having the same problem here. In firefox i disabled autogaincontrol, echo and noise cancellation and audio quality is terrific. I would love to turn those features off in riot-desktop as well since it makes it unusable for me when transmitting anything other than speech.

@t3chguy t3chguy mentioned this issue Oct 3, 2020
Closed
@BloodyIron
Copy link

This problem isn't going away. Google isn't interested in fixing this in Chromium/derivatives. Can we please get this implemented?

More details from a Chromium developer: https://bugs.chromium.org/p/chromium/issues/detail?id=435112#c3

This is hurting the experience for Element VoIP in the most popular browsers. And there is a method to solve this already. Can we get this added to a milestone already? It's been years.

@tleydxdy
Copy link

yes, this problem causes the other side to hear deafeningly loud static, I would consider this a major bug

@SimonBrandner SimonBrandner mentioned this issue Apr 28, 2021
Closed
@SimonBrandner SimonBrandner added O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Aug 30, 2021
@poperigby
Copy link

poperigby commented Nov 23, 2021 •
edited
Loading

I think this is quite important. I was on a call with my friend, and the volume was just fine. But the next day, my microphone volume was fluctuating wildly and really hurting his ears. That only happens in the desktop client though.

@t3chguy t3chguy mentioned this issue Feb 4, 2022
Closed
@Mewsen
Copy link

Mewsen commented Apr 10, 2022

This is so important, how is this not implemented yet... imo the element desktop client is unusable for conference calls without it...

@BloodyIron
Copy link

The auto-gain is really obnoxious, it keeps turning it down way too low and people can't hear me. Need to turn volume back up, only for it to go back down. :/ no way to turn off or adjust behaviour...

@tleydxdy
Copy link

I have resorted to using https://github.com/joeywatts/disable-autogain-control-extension

@BloodyIron
Copy link

While that can work as a stop-gap, convincing others to use that is really problematic. Also, using that on mobile?

@t3chguy
Copy link
Member

t3chguy commented Apr 12, 2022

Also, using that on mobile?

Any solution from this repo won't work on mobile

@t3chguy t3chguy mentioned this issue Jun 10, 2022
Closed
@t3chguy
Copy link
Member

t3chguy commented Jun 13, 2022

Needs matrix-org/matrix-js-sdk#2451

@SimonBrandner SimonBrandner mentioned this issue Jun 14, 2022
Merged
@vi vi mentioned this issue Sep 16, 2022
Merged
SimonBrandner pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Nov 9, 2022
@MrAnno
Advanced audio processing settings (#8759)
afdf289 
Co-authored-by: Šimon Brandner <simon.bra.ag@gmail.com>
Fixes element-hq/element-web#6278
Fixes undefined
su-ex added a commit to SchildiChat/element-desktop that referenced this issue Nov 25, 2022
@su-ex
Merge tag 'v1.11.15' into sc
dbc2e90 
* Switch to notarytool ([\element-hq#440](element-hq#440)).
* Make clear notifications work with threads ([\#9575](matrix-org/matrix-react-sdk#9575)). Fixes element-hq/element-web#23751.
* Change "None" to "Off" in notification options ([\#9539](matrix-org/matrix-react-sdk#9539)). Contributed by @Arnei.
* Advanced audio processing settings ([\#8759](matrix-org/matrix-react-sdk#8759)). Fixes element-hq/element-web#6278. Contributed by @MrAnno.
* Add way to create a user notice via config.json ([\#9559](matrix-org/matrix-react-sdk#9559)).
* Improve design of the rich text editor ([\#9533](matrix-org/matrix-react-sdk#9533)).
* Enable user to zoom beyond image size ([\#5949](matrix-org/matrix-react-sdk#5949)). Contributed by @jaiwanth-v.
* Fix: Move "Leave Space" option to the bottom of space context menu ([\#9535](matrix-org/matrix-react-sdk#9535)). Contributed by @hanadi92.
* Fix encrypted message search indexing for non-default `--profile` instances. ([\element-hq#433](element-hq#433)).
* Make build scripts work on NixOS ([\#23740](element-hq/element-web#23740)).
* Fix integration manager `get_open_id_token` action and add E2E tests ([\#9520](matrix-org/matrix-react-sdk#9520)).
* Fix links being mangled by markdown processing ([\#9570](matrix-org/matrix-react-sdk#9570)). Fixes element-hq/element-web#23743.
* Fix: inline links selecting radio button ([\#9543](matrix-org/matrix-react-sdk#9543)). Contributed by @hanadi92.
* fix wrong error message in registration when phone number threepid is in use. ([\#9571](matrix-org/matrix-react-sdk#9571)). Contributed by @bagvand.
* Fix missing avatar for show current profiles ([\#9563](matrix-org/matrix-react-sdk#9563)). Fixes element-hq/element-web#23733.
* fix read receipts trickling down correctly ([\#9567](matrix-org/matrix-react-sdk#9567)). Fixes element-hq/element-web#23746.
* Resilience fix for homeserver without thread notification support ([\#9565](matrix-org/matrix-react-sdk#9565)).
* Don't switch to the home page needlessly after leaving a room ([\#9477](matrix-org/matrix-react-sdk#9477)).
* Differentiate download and decryption errors when showing images ([\#9562](matrix-org/matrix-react-sdk#9562)). Fixes element-hq/element-web#3892.
* Close context menu when a modal is opened to prevent user getting stuck ([\#9560](matrix-org/matrix-react-sdk#9560)). Fixes element-hq/element-web#15610 and element-hq/element-web#10781.
* Fix TimelineReset handling when no room associated ([\#9553](matrix-org/matrix-react-sdk#9553)).
* Always use current profile on thread events ([\#9524](matrix-org/matrix-react-sdk#9524)). Fixes element-hq/element-web#23648.
* Fix `ThreadView` tests not using thread flag ([\#9547](matrix-org/matrix-react-sdk#9547)).
* Fix regressions around media uploads failing and causing soft crashes ([\#9549](matrix-org/matrix-react-sdk#9549)). Fixes matrix-org/element-web-rageshakes#16831, matrix-org/element-web-rageshakes#16824 matrix-org/element-web-rageshakes#16810 and element-hq/element-web#23641.
* Handle deletion of `m.call` events ([\#9540](matrix-org/matrix-react-sdk#9540)). Fixes element-hq/element-web#23663.
* Fix /myroomavatar slash command ([\#9536](matrix-org/matrix-react-sdk#9536)). Fixes matrix-org/synapse#14321.
* Fix incorrect notification count after leaving a room with notifications ([\#9518](matrix-org/matrix-react-sdk#9518)). Contributed by @Arnei.
su-ex added a commit to SchildiChat/element-web that referenced this issue Nov 25, 2022
@su-ex
Merge tag 'v1.11.15' into sc
887be88 
* Make clear notifications work with threads ([\element-hq#9575](matrix-org/matrix-react-sdk#9575)). Fixes element-hq#23751.
* Change "None" to "Off" in notification options ([\element-hq#9539](matrix-org/matrix-react-sdk#9539)). Contributed by @Arnei.
* Advanced audio processing settings ([\element-hq#8759](matrix-org/matrix-react-sdk#8759)). Fixes element-hq#6278. Contributed by @MrAnno.
* Add way to create a user notice via config.json ([\element-hq#9559](matrix-org/matrix-react-sdk#9559)).
* Improve design of the rich text editor ([\element-hq#9533](matrix-org/matrix-react-sdk#9533)). Contributed by @florianduros.
* Enable user to zoom beyond image size ([\element-hq#5949](matrix-org/matrix-react-sdk#5949)). Contributed by @jaiwanth-v.
* Fix: Move "Leave Space" option to the bottom of space context menu ([\element-hq#9535](matrix-org/matrix-react-sdk#9535)). Contributed by @hanadi92.
* Make build scripts work on NixOS ([\element-hq#23740](element-hq#23740)).
* Fix integration manager `get_open_id_token` action and add E2E tests ([\element-hq#9520](matrix-org/matrix-react-sdk#9520)).
* Fix links being mangled by markdown processing ([\element-hq#9570](matrix-org/matrix-react-sdk#9570)). Fixes element-hq#23743.
* Fix: inline links selecting radio button ([\element-hq#9543](matrix-org/matrix-react-sdk#9543)). Contributed by @hanadi92.
* Fix wrong error message in registration when phone number threepid is in use. ([\element-hq#9571](matrix-org/matrix-react-sdk#9571)). Contributed by @bagvand.
* Fix missing avatar for show current profiles ([\element-hq#9563](matrix-org/matrix-react-sdk#9563)). Fixes element-hq#23733.
* Fix read receipts trickling down correctly ([\element-hq#9567](matrix-org/matrix-react-sdk#9567)). Fixes element-hq#23746.
* Resilience fix for homeserver without thread notification support ([\element-hq#9565](matrix-org/matrix-react-sdk#9565)).
* Don't switch to the home page needlessly after leaving a room ([\element-hq#9477](matrix-org/matrix-react-sdk#9477)).
* Differentiate download and decryption errors when showing images ([\element-hq#9562](matrix-org/matrix-react-sdk#9562)). Fixes element-hq#3892.
* Close context menu when a modal is opened to prevent user getting stuck ([\element-hq#9560](matrix-org/matrix-react-sdk#9560)). Fixes element-hq#15610 and element-hq#10781.
* Fix TimelineReset handling when no room associated ([\element-hq#9553](matrix-org/matrix-react-sdk#9553)).
* Always use current profile on thread events ([\#9524](matrix-org/matrix-react-sdk#9524)). Fixes element-hq#23648.
* Fix `ThreadView` tests not using thread flag ([\element-hq#9547](matrix-org/matrix-react-sdk#9547)). Contributed by @MadLittleMods.
* Handle deletion of `m.call` events ([\element-hq#9540](matrix-org/matrix-react-sdk#9540)). Fixes element-hq#23663.
* Fix incorrect notification count after leaving a room with notifications ([\element-hq#9518](matrix-org/matrix-react-sdk#9518)). Contributed by @Arnei.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Nov 25, 2022
@su-ex
Merge tag 'v3.61.0' into sc
9bc034a 
* Make clear notifications work with threads ([\matrix-org#9575](matrix-org#9575)). Fixes element-hq/element-web#23751.
* Change "None" to "Off" in notification options ([\matrix-org#9539](matrix-org#9539)). Contributed by @Arnei.
* Advanced audio processing settings ([\matrix-org#8759](matrix-org#8759)). Fixes element-hq/element-web#6278. Contributed by @MrAnno.
* Add way to create a user notice via config.json ([\matrix-org#9559](matrix-org#9559)).
* Improve design of the rich text editor ([\matrix-org#9533](matrix-org#9533)). Contributed by @florianduros.
* Enable user to zoom beyond image size ([\matrix-org#5949](matrix-org#5949)). Contributed by @jaiwanth-v.
* Fix: Move "Leave Space" option to the bottom of space context menu ([\matrix-org#9535](matrix-org#9535)). Contributed by @hanadi92.
* Fix integration manager `get_open_id_token` action and add E2E tests ([\matrix-org#9520](matrix-org#9520)).
* Fix links being mangled by markdown processing ([\matrix-org#9570](matrix-org#9570)). Fixes element-hq/element-web#23743.
* Fix: inline links selecting radio button ([\matrix-org#9543](matrix-org#9543)). Contributed by @hanadi92.
* fix wrong error message in registration when phone number threepid is in use. ([\matrix-org#9571](matrix-org#9571)). Contributed by @bagvand.
* Fix missing avatar for show current profiles ([\matrix-org#9563](matrix-org#9563)). Fixes element-hq/element-web#23733.
* fix read receipts trickling down correctly ([\matrix-org#9567](matrix-org#9567)). Fixes element-hq/element-web#23746.
* Resilience fix for homeserver without thread notification support ([\matrix-org#9565](matrix-org#9565)).
* Don't switch to the home page needlessly after leaving a room ([\matrix-org#9477](matrix-org#9477)).
* Differentiate download and decryption errors when showing images ([\matrix-org#9562](matrix-org#9562)). Fixes element-hq/element-web#3892.
* Close context menu when a modal is opened to prevent user getting stuck ([\matrix-org#9560](matrix-org#9560)). Fixes element-hq/element-web#15610 and element-hq/element-web#10781.
* Fix TimelineReset handling when no room associated ([\matrix-org#9553](matrix-org#9553)).
* Always use current profile on thread events ([\matrix-org#9524](matrix-org#9524)). Fixes element-hq/element-web#23648.
* Fix `ThreadView` tests not using thread flag ([\matrix-org#9547](matrix-org#9547)). Contributed by @MadLittleMods.
* Handle deletion of `m.call` events ([\matrix-org#9540](matrix-org#9540)). Fixes element-hq/element-web#23663.
* Fix incorrect notification count after leaving a room with notifications ([\matrix-org#9518](matrix-org#9518)). Contributed by @Arnei.
@vi
Copy link

vi commented Aug 25, 2023 •
edited
Loading

I see this issue as "closed as completed by a commit", but on app.element.io I see only "Noise suppression" and
"Echo cancellation" advanced audio settings, not "Automatic microphone gain control".

Shall the issue be reopened?

I see now it is "Automatically adjust the microphone volume", not in "advanced" settings, but in usual "Voice settings" above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-VoIP O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Advanced audio processing settings MrAnno/matrix-react-sdk